Skip to content

persistit: stabilize flaky MVCCPruneTest.testPruneAlternatingAbortedAndCommittedVersions #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vharseko merged 1 commit into from
Jul 12, 2026
Merged

persistit: stabilize flaky MVCCPruneTest.testPruneAlternatingAbortedAndCommittedVersions #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion persistit/core/src/test/java/com/persistit/MVCCPruneTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* Portions Copyrighted 2026 3A Systems, LLC
*/

package com.persistit;
Expand Down Expand Up @@ -253,6 +254,15 @@ public void testPruneAlternatingAbortedAndCommittedVersions() throws PersistitEx
storePrimordial(ex1, KEY, VALUE);

for (int i = 0; i < VERSIONS.length; ++i) {
/*
* The prune that runs inside each store consults the active
* transaction cache: a stale cache conservatively keeps the
* previous committed version, a fresh one removes it. Settle the
* cache before every store so the surviving version count does
* not depend on whether the background TXN_UPDATE timer fired
* mid-loop (issue #272).
*/
_persistit.getTransactionIndex().updateActiveTransactionCache();
trx1.begin();
try {
store(ex1, KEY, VALUE + VERSIONS[i] + i);
Expand All @@ -265,7 +275,7 @@ public void testPruneAlternatingAbortedAndCommittedVersions() throws PersistitEx
trx1.end();
}
}
final int VERSIONS_NOW_REMOVED_BY_PRUNING_BEFORE_STORE = 2;
final int VERSIONS_NOW_REMOVED_BY_PRUNING_BEFORE_STORE = 4;
assertEquals("stored versions", VERSIONS.length + 1 - VERSIONS_NOW_REMOVED_BY_PRUNING_BEFORE_STORE,
storedVersionCount(ex2, KEY));

Expand Down
Loading