Skip to content

Qualify the LinkedHashMap size() call in removeEldestEntry (CodeQL java/subtle-inherited-call) #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vharseko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Qualify the LinkedHashMap size() call in removeEldestEntry (CodeQL java/subtle-inherited-call) #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...2-module/src/main/java/org/forgerock/authz/modules/oauth2/AccessTokenValidationCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* information: "Portions copyright [year] [name of copyright owner]".
*
* Copyright 2014 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

package org.forgerock.authz.modules.oauth2;
Expand Down Expand Up @@ -47,7 +48,11 @@ class AccessTokenValidationCache {

@Override
protected boolean removeEldestEntry(Map.Entry<String, AccessTokenValidationResponse> eldestEntry) {
return size() > maxSize;
// size() refers to this LinkedHashMap's own size, not the enclosing
// AccessTokenValidationCache.size() (which would re-acquire the read lock while a
// put() already holds the write lock). Qualify with super to make that explicit
// (CodeQL java/subtle-inherited-call).
return super.size() > maxSize;
}
};
}
Expand Down
Loading