Skip to content

Synchronize overrides of synchronized methods (CodeQL java/non-sync-override) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vharseko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Synchronize overrides of synchronized methods (CodeQL java/non-sync-override) #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e074761
Synchronize overrides of synchronized methods (CodeQL java/non-sync-o…
vharseko Jul 8, 2026
85061de
Merge branch 'master' into features/codeql-non-sync-override
vharseko Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ons/http-framework/core/src/main/java/org/forgerock/http/io/ByteArrayBranchingStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* Copyright 2010–2011 ApexIdentity Inc.
* Portions Copyright 2011-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

package org.forgerock.http.io;
Expand Down Expand Up @@ -102,7 +103,7 @@ public boolean markSupported() {
}

@Override
public void mark(int readlimit) {
public synchronized void mark(int readlimit) {
mark = position;
}

Expand Down
2 changes: 1 addition & 1 deletion persistit/core/src/main/java/com/persistit/PersistitMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ public static class PersistitMapException extends RuntimeException {
}

@Override
public Throwable getCause() {
public synchronized Throwable getCause() {
return _exception;
}
}
Expand Down
4 changes: 2 additions & 2 deletions persistit/core/src/main/java/com/persistit/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5056,12 +5056,12 @@ protected final void readStreamHeader() throws IOException {
}

@Override
public void mark(final int readLimit) {
public synchronized void mark(final int readLimit) {
_mark = _value._next;
}

@Override
public void reset() throws IOException {
public synchronized void reset() throws IOException {
if (_mark < 0) {
throw new IOException("No mark");
} else {
Expand Down
Loading