Re-enable three previously disabled tests#198
Open
vharseko wants to merge 1 commit into
Open
Conversation
These TestNG methods were annotated enabled=false and never ran in the default build: - openidm-scheduler ScheduleConfigServiceTest.invalidConfigParsingTest: still valid, passes as-is. - openidm-provisioner-openicf OpenICFProvisionerServiceTest.testPagedSearch: valid, passes against the groovy and groovyremote connector servers. - openidm-provisioner-openicf ConnectorInfoProviderServiceTest.testPropertiesToEncrypt: its Solaris connector fixture had been deleted and the Solaris connector no longer exists in the OpenICF platform, so the "properties to encrypt" detection is now exercised against the Groovy connector, whose schema marks customSensitiveConfiguration as a GuardedString.
vharseko
added
test
maximthomas
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three TestNG methods were annotated
enabled = falseand therefore never executed in the defaultmvn testbuild. This re-enables them.ScheduleConfigServiceTest.invalidConfigParsingTestOpenICFProvisionerServiceTest.testPagedSearch(groovy, groovyremote)ConnectorInfoProviderServiceTest.testPropertiesToEncryptNotes on
testPropertiesToEncryptIts original classpath fixture
org.forgerock.openidm.provisioner.openicf.impl.OpenICFProvisionerServiceSolarisConnectorTest.jsonhad been deleted (commit ef25ec3, 2013) and the Solaris connector no longer exists in the OpenICF platform (available connectors: csvfile, databasetable, groovy, kerberos, ldap, ssh, xml). Restoring the fixture alone fails withWaitForMetaData: ConnectorInfo is not availablebecause the connector bundle cannot be loaded.The test's intent — verifying that
getPropertiesToEncryptreturns the pointers to confidential/GuardedStringconfiguration properties — is preserved by retargeting it to the Groovy connector (already copied into the test connectors directory), whose schema markscustomSensitiveConfigurationas aGuardedString. AnassertThat(result).isNotEmpty()guard was added so the assertion loop no longer passes vacuously on an empty result.Verification
mvn -pl openidm-scheduler test -Dtest=ScheduleConfigServiceTest→ 2/2 passmvn -pl openidm-provisioner-openicf test -Dtest=ConnectorInfoProviderServiceTest→ 4/4 passmvn -pl openidm-provisioner-openicf test -Dtest=OpenICFProvisionerServiceTest#testPagedSearch→ 2/2 pass