fix(live): sync edited RTSP URL without an app restart#12
Merged
Conversation
MainView hosted CurrentPage in two ContentControls (one per layout), so the same page VM bound to two views — both fired Loaded and double-activated the session (double Acquire + "Already started"), leaking a coordinator ref so the stale session was reused on next open. - MainView: host CurrentPage in a single shared ContentControl; only the chrome (sidebar / bottom nav) toggles on the breakpoint. ContentPadding moved to a property since one host can't switch padding via two layouts - SingleCameraPageViewModel: make Activate/Dispose idempotent (re-entrancy gate + dispose guard) so a session is acquired and released exactly once - GridPageViewModel: rebuild a tile when its effective stream URL changes instead of keeping the stale tile by Id (refreshes on next Live-tab entry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MainView hosted CurrentPage in two ContentControls (one per layout), so the same page VM bound to two views — both fired Loaded and double-activated the session (double Acquire + "Already started"), leaking a coordinator ref so the stale session was reused on next open.
Summary
Fixing issue #7
MainView hosted CurrentPage in two ContentControls (one per layout), so the same page VM bound to two views — both fired Loaded and double-activated the session (double Acquire + "Already started"), leaking a coordinator ref so the stale session was reused on next open.
Related
Type
Checklist
TreatWarningsAsErrors=true).dotnet test); new Core logic has unit tests.AppreferencesCoreonly (Infrastructure / Video / Devices wired via DI in a head).Platforms tested
Screenshots / notes