Skip to content

fix(i18n): refresh all localized bindings live on language switch #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyldev merged 1 commit into from
Jun 6, 2026
Merged

fix(i18n): refresh all localized bindings live on language switch #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/OpenIPC.Viewer.App/Services/Localizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@ namespace OpenIPC.Viewer.App.Services;

// Tiny ICU-free localizer. Static singleton because XAML's {Binding [Key],
// Source={x:Static svc:Localizer.Instance}} pattern needs a static reference.
// PropertyChanged on "Item[]" tells all indexed bindings to re-evaluate when
// SetLanguage flips the active dict — no relaunch needed.
// SetLanguage raises PropertyChanged with an empty name ("everything changed")
// so every binding on Localizer.Instance re-reads when the active dict flips —
// no relaunch needed. Note: the WPF "Item[]" indexer convention does NOT work
// here — Avalonia's accessor only re-reads when PropertyName equals the CLR
// indexer name ("Item") or is null/empty, so persistent controls like the
// bottom nav stayed stale on "Item[]". Empty name is the reliable signal.
//
// EN/RU only for now; adding a third language = one more dict + one more
// LangCode value. Missing keys fall back to the key itself, so adding a new
Expand Down Expand Up @@ -41,7 +45,9 @@ public void SetLanguage(LangCode code)
_ => English,
};
_active = resolved;
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs("Item[]"));
// Empty/null name = "all properties changed"; Avalonia's INPC accessor
// re-reads on string.IsNullOrEmpty(PropertyName). "Item[]" would not match.
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(string.Empty));
}

private static LangCode DetectSystem()
Expand Down
Loading