Conversation
The code-review and github-pr-review skills have been merged into a single code-review skill in the extensions repo. Update documentation references accordingly. Changes: - Update code review use case page: reflect combined skill, fix links - Update SDK pr-review guide: note about combined skill, mark review-style as deprecated in action inputs table - Mark review-style input as deprecated in both action input tables Co-authored-by: openhands <openhands@all-hands.dev>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
Documentation changes accurately reflect the skill merger. Two minor suggestions for improved clarity.
| | Style | Description | Best For | | ||
| |-------|-------------|----------| | ||
| | **Standard** ([`/codereview`](https://github.com/OpenHands/extensions/tree/main/skills/codereview)) | Pragmatic, constructive feedback focusing on code quality, security, and best practices | Day-to-day code reviews | | ||
| | **Standard** ([`/codereview`](https://github.com/OpenHands/extensions/tree/main/skills/code-review)) | Pragmatic, constructive feedback focusing on code quality, security, and best practices. Includes GitHub API posting instructions. | Day-to-day code reviews | |
There was a problem hiding this comment.
🟡 Suggestion: The phrase "Includes GitHub API posting instructions." is an implementation detail that may confuse users. Both review styles will post to GitHub in practice (since the plugin loads both skill files), so this phrase suggests only the Standard style posts reviews, which isn't true.
Consider removing this phrase or rephrasing to clarify that all reviews are posted to GitHub regardless of style. The original description was already clear that it's a code review tool.
| | `llm-model` | LLM model to use | Yes | - | | ||
| | `llm-base-url` | LLM base URL (for custom endpoints) | No | `''` | | ||
| | `review-style` | Review style: `standard` or `roasted` | No | `roasted` | | ||
| | `review-style` | **[Deprecated]** Review style: `standard` or `roasted`. Both styles now use the combined `code-review` skill. | No | `roasted` | |
There was a problem hiding this comment.
🟡 Suggestion: The deprecation message "Both styles now use the combined code-review skill" is technically confusing since the roasted style still uses the codereview-roasted skill file. What's actually changed is that GitHub API posting is now built into the workflow, making this parameter redundant.
Consider clarifying: "[Deprecated] GitHub API posting is now built into both review styles, making this parameter redundant." This better explains WHY it's deprecated.
3 participants
Summary
The
code-reviewandgithub-pr-reviewskills have been merged into a singlecode-reviewskill in the extensions repo. This PR updates documentation references accordingly.Companion PR: OpenHands/extensions#173
Changes
openhands/usage/use-cases/code-review.mdxskills/code-review(was pointing toskills/codereview)review-styleaction input as deprecatedsdk/guides/github-workflows/pr-review.mdxcode-reviewskill now includes GitHub API posting instructionsreview-styleaction input as deprecated in action inputs tableThis PR was created by an AI assistant (OpenHands) on behalf of the user.