Conversation
- Update keyword.mdx example to use github skill instead of yummy example - Add context management note explaining github/gitlab skills triggering - Create Adding New Skills guide explaining /add-skill action and storage locations - Create Creating New Skills guide with best practices for scope, naming, triggers, and content - Create Plugins overview explaining plugin structure and comparison with skills - Update docs.json navigation to include new pages in appropriate sections - Add cross-references between related documentation pages for better user flow Co-authored-by: openhands <openhands@all-hands.dev>
- Add Tip callout in Quick Start section mentioning skill-creator - Explain that users can ask OpenHands to 'create a skill' for guided assistance - Helpful for new users learning best practices Co-authored-by: openhands <openhands@all-hands.dev>
- Move skill-creator to be the first and primary method - Present manual approach as alternative for those who prefer it - Make it clear that skill-creator is the recommended starting point - Better reflects that guided creation is simpler than manual setup Co-authored-by: openhands <openhands@all-hands.dev>
|
@OpenHands please fix pre commit hooks |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- Add missing comma after overview/plugins on line 48 - Add missing comma after overview/skills/creating on line 59 - Resolves Mintlify broken links check failure Co-authored-by: openhands <openhands@all-hands.dev>
SummaryI've successfully fixed the pre-commit hook issues for PR #339. What Was WrongThe Mintlify "Check Broken Links" CI check was failing due to JSON syntax errors in Changes MadeFixed two missing commas in
Verification✅ Validated JSON syntax using Python's json.tool - confirmed valid Next StepsThe CI checks should automatically re-run and should now pass. The Mintlify validation will be able to properly parse the |
|
|
I'm on it! neubig can track my progress at all-hands.dev |
Final SummaryI analyzed PR #339 "Add Skills and Plugins documentation" by performing three tasks as requested: 1. Blog Post Coverage AnalysisAnswer: NO - The PR does NOT cover all elements from the blog post. The blog at https://openhands.dev/blog/20260227-creating-effective-agent-skills has a major section (~40% of content) on "Monitoring and Improving Skills" that is completely missing from the PR documentation:
2. Instruction Testing on llm-support-tracker
3. /codereview-roasted Verdict🔴 Needs Improvement - Critical issues found:
No code changes were made. This was an analysis/review task only. The findings should be addressed by the PR author before merging. |
neubig
left a comment
There was a problem hiding this comment.
@juanmichelini could you look at the openhands feedback, reflect it, and run the same review prompt again and see if you get a good result?
…latives - Create dedicated monitoring.mdx page (169 lines) for production skill monitoring - 4-part workflow: logging, evaluating, dashboarding, aggregating - Practical PR review examples with actual metrics - Links to SDK observability guide and GitHub workflows - Update creating.mdx: Remove superlatives, add monitoring links - 'Easiest' → 'Automated Approach' - Added Info callout linking to monitoring page - Enhanced Further Reading with monitoring + observability links - Update plugins.mdx: Remove conversational tone - 'Think of' → direct statement - 'knowledge packages' → 'specialized prompts' - 'Easy' → 'Quick' - Update skills.mdx: Add monitoring link to Learn More section - Add DOCS_UPDATES.md: Complete change log with justifications All changes maintain technical, down-to-earth tone without superlatives. Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
- Remove 'prompting-best-practices' from Onboarding (already in Essential Guidelines) - Remove 'overview/skills/repo' from Onboarding (already in Skills group under Essential Guidelines) - Remove 'model-context-protocol' from Product Guides (already in Essential Guidelines) - Remove Skills group from Product Guides (already in Essential Guidelines) Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable: Strong documentation with comprehensive coverage and good structure. Two important accuracy issues need fixing (hook event types and author field format), but overall excellent work documenting Skills and Plugins.
|
@OpenHands please address reviewers concerns and resolve conflicts too |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- resolve the docs.json merge conflict against origin/main - document both supported plugin manifest directories - correct plugin hook event names to match the SDK - document both supported plugin author formats Co-authored-by: openhands <openhands@all-hands.dev>
|
Resumen final de lo hecho desde el último resumen: Estado
Cambios nuevos realizados
Concisión de los cambios
Validación
Nota pendiente
|
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Comprehensive, well-structured documentation with practical examples. One minor navigation organization question worth clarifying.
…scoverability This change consolidates all skills-related documentation under the Skills group for better discoverability, addressing reviewer feedback about navigation organization clarity. All skills pages are now grouped together: - overview/skills (overview) - overview/skills/repo - overview/skills/keyword - overview/skills/org - overview/skills/public - overview/skills/adding - overview/skills/creating - overview/skills/monitoring
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable: Comprehensive documentation with good structure and real-world examples. One technical inaccuracy in hooks example needs fixing.
Address review comment: clarify that GITHUB_TOKEN is automatically used by /add-skill command via GitHub API, and distinguish from manual git clone authentication methods like SSH keys or token in URL.
- Fix hook command template syntax: use $OPENHANDS_PROJECT_DIR instead
of unsupported {file_path} syntax, document available env vars
- Complete SDK example: add LLM, Agent imports and SecretStr usage
- Add skill-creator context: link to public skills library
|
All review comments have been addressed and resolved. Could you please re-review the PR? |
all-hands-bot
left a comment
There was a problem hiding this comment.
Comprehensive documentation work with one accuracy issue that needs fixing.
Overview
This PR adds comprehensive documentation for Skills and Plugins, improving the user experience across all skill levels (new, experienced, and power users).
Changes
1. Updated Keyword Skills Example
2. Added "Adding New Skills" Page
/add-skillactionoverview/skills/adding.mdx(under Skills section)3. Added "Creating New Skills" Page
overview/skills/creating.mdx(under Skills group in Product Guides)4. Added "Creating New Skills" Page
overview/skills/creating.mdx(under Skills group in Product Guides)4. Added Plugins Overview Page
overview/plugins.mdx(same level as Skills in Product Guides)5. Updated Navigation Structure
6. Enhanced Cross-References
User Flow Analysis
New Users (don't know the terms yet)
Experienced Users (trying things out, want to scratch an itch)
Power Users (want to do things properly)
Tone and Style
All new content maintains consistency with existing docs:
Checklist