Skip to content

add results handling for new worker-based execution - #2114

Open
atravitz wants to merge 21 commits into
epic/execution_improvementsfrom
feat/exorcist-results-handling
Open

add results handling for new worker-based execution#2114
atravitz wants to merge 21 commits into
epic/execution_improvementsfrom
feat/exorcist-results-handling

Conversation

@atravitz

@atravitz atravitz commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

resolves #2119

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing. (this will happen before merge into main)
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 4 times, most recently from 8398290 to e21142b Compare July 31, 2026 22:11
@atravitz atravitz linked an issue Aug 3, 2026 that may be closed by this pull request
@atravitz atravitz self-assigned this Aug 3, 2026
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from e21142b to 2521bcf Compare August 4, 2026 14:06
@atravitz
atravitz force-pushed the epic/execution_improvements branch from 2f467d3 to 6fc30c6 Compare August 4, 2026 14:08
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from 2521bcf to 1bccca4 Compare August 6, 2026 22:10
@atravitz
atravitz force-pushed the epic/execution_improvements branch from 6fc30c6 to a07f1c8 Compare August 7, 2026 19:51
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 2 times, most recently from 8680580 to 9658ce4 Compare August 10, 2026 22:33
@atravitz
atravitz force-pushed the epic/execution_improvements branch from a07f1c8 to a85734f Compare August 12, 2026 19:39
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from 9658ce4 to cb7eb9e Compare August 12, 2026 19:50
@github-actions

Copy link
Copy Markdown

🚨 API breaking changes detected! 🚨

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main
src/openfe/tests/storage/test_resultclient.py:0: <module>:
Public object was removed

src/openfe/tests/storage/test_metadatastore.py:0: <module>:
Public object was removed

src/openfe/tests/storage/test_resultserver.py:0: <module>:
Public object was removed

src/openfe/storage/metadatastore.py:0: <module>:
Public object was removed

src/openfe/storage/resultserver.py:0: <module>:
Public object was removed

src/openfe/storage/resultclient.py:0: <module>:
Public object was removed


$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main
src/openfecli/commands/plan_rbfe_network.py:121: plan_rbfe_network(warehouse):
Parameter was added as required


@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from 0847bb2 to fee41ef Compare August 12, 2026 22:26
@atravitz
atravitz changed the base branch from epic/execution_improvements to dev/updates_to_worker_based_execution August 12, 2026 22:26
Base automatically changed from dev/updates_to_worker_based_execution to epic/execution_improvements August 12, 2026 22:28
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 2 times, most recently from d4d3f79 to 2fd2923 Compare August 12, 2026 22:34
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (c11378c) to head (391ae10).

Files with missing lines Patch % Lines
src/openfe/storage/warehouse.py 78.78% 14 Missing ⚠️
src/openfe/orchestration/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           epic/execution_improvements    #2114   +/-   ##
============================================================
  Coverage                        90.60%   90.61%           
============================================================
  Files                              219      219           
  Lines                            21608    21692   +84     
============================================================
+ Hits                             19579    19657   +78     
- Misses                            2029     2035    +6     
Flag Coverage Δ
fast-tests 90.61% <86.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz force-pushed the epic/execution_improvements branch from a6fd672 to cc8edd5 Compare August 14, 2026 16:01
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 4 times, most recently from 8c3377f to a8cff0c Compare August 14, 2026 20:41
@atravitz
atravitz changed the base branch from epic/execution_improvements to dev/warehouse_usability August 18, 2026 00:12
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 2 times, most recently from 0d25753 to 8f37dc8 Compare August 18, 2026 00:33
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from 41b170a to 90cc3b4 Compare August 20, 2026 15:24
@atravitz
atravitz marked this pull request as ready for review August 20, 2026 15:36
Base automatically changed from dev/warehouse_usability to epic/execution_improvements August 20, 2026 21:30
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch 2 times, most recently from 25a3ffc to d3b54db Compare August 20, 2026 22:55
@ethanholz

ethanholz commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I like the implementations I see here. The results model makes sense.

@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from d3b54db to 119db9e Compare August 20, 2026 23:13
@IAlibay
IAlibay self-requested a review August 21, 2026 15:34
@atravitz
atravitz force-pushed the feat/exorcist-results-handling branch from bb09bf6 to 391ae10 Compare August 21, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

worker-based execution: add basic results gathering support

2 participants