update for new cinnabar API#311
Open
jthorton wants to merge 3 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
# Conflicts: # environment.yaml
jthorton
commented
Jun 12, 2026
| @@ -5,69 +5,29 @@ | |||
| "id": "ddae61fd-fa15-4be9-9160-ba3e195c67dc", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "# Plotting OpenFE DG results against experiment using Cinnabar v0.4\n", | |||
| "# Plotting OpenFE DG results against experiment using Cinnabar v0.6.0\n", | |||
Contributor
Author
There was a problem hiding this comment.
This notebook is not included in the current docs do we still want this?
Contributor
There was a problem hiding this comment.
It might be useful for people who run ABFEs not having to go throught he RBFE related content in the general plotting notebook, but maybe it's also not super important? If we keep it, we should definitely add it to the docs!
| @@ -5,69 +5,29 @@ | |||
| "id": "ddae61fd-fa15-4be9-9160-ba3e195c67dc", | |||
Contributor
There was a problem hiding this comment.
Maybe we could also add here or gathered with gather_abfe and refer to the ABFE CLI tutorial?
Reply via ReviewNB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.