(1/n) Refactor benchmark execution behind a shared runner interface - #79
Draft
kargibora wants to merge 1 commit into
Draft
(1/n) Refactor benchmark execution behind a shared runner interface#79kargibora wants to merge 1 commit into
kargibora wants to merge 1 commit into
Conversation
Extract shared baseline and model setup while keeping the existing pairwise workflow as the only registered adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is one of the large refactors that is discussed, for implementing more proper
taskdefinition in whichtaskis defined as a.yamlfiles that calls certain functions with set of values (like dataset revision, dataset...).Summary
The current generate-and-evaluate flow is implemented directly inside
generate_and_evaluate.py. Besides runningpairwise evaluation, this module is also responsible for selecting the workflow, resolving task baselines, constructing
generation settings, and initializing the judge.
This works for the current benchmarks, but adding a benchmark with a different execution flow would require adding more
task-specific conditions to the same module. The goal of this PR is to introduce a small runner abstraction before
adding further benchmark integrations.
What changed
This PR adds a
BenchmarkAdaptercontract that connects supported tasks to a benchmark runner. The existing pairwiseevaluation remains the only registered implementation and acts as the fallback, so the runtime behavior of existing
tasks is preserved.
The following responsibilities were also extracted from
generate_and_evaluate.py:judgearena/baselines.py.judgearena/benchmark.py.run_pairwise()and selected through the adapter registry.The execution path is now: