Skip to content

Recoup of #2517 "Implement caller"#2603

Merged
wixoaGit merged 24 commits into
OpenDreamProject:masterfrom
tontyGH:caller-recoup
Jun 12, 2026
Merged

Recoup of #2517 "Implement caller"#2603
wixoaGit merged 24 commits into
OpenDreamProject:masterfrom
tontyGH:caller-recoup

Conversation

@tontyGH

@tontyGH tontyGH commented May 28, 2026

Copy link
Copy Markdown
Contributor

I implemented the RefType for callees because locating a stale callee with the debugger would crash the debugger.

@boring-cyborg boring-cyborg Bot added Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels May 28, 2026
Comment thread OpenDreamRuntime/DreamThread.cs Fixed
Comment thread OpenDreamRuntime/DreamThread.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
@tontyGH tontyGH changed the title Recup of #2517 "Implement caller" Recoup of #2517 "Implement caller" May 28, 2026
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
@tontyGH tontyGH marked this pull request as draft May 29, 2026 01:30
@github-actions github-actions Bot added size/M and removed size/L labels May 29, 2026
@tontyGH tontyGH marked this pull request as ready for review May 29, 2026 18:49
Comment thread OpenDreamRuntime/DreamThread.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
@github-actions github-actions Bot added size/L and removed size/M labels May 29, 2026
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
@tontyGH

tontyGH commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I think we're good.

Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
@wixoaGit

Copy link
Copy Markdown
Member

locating a stale callee with the debugger would crash the debugger.

The debugger should be able to handle a variable throwing an exception if you try to read it. That can be another PR though, if you want to open an issue for it.

Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Outdated
Comment thread OpenDreamRuntime/Procs/DMProc.cs Outdated
Comment thread OpenDreamRuntime/Procs/DMProc.cs Outdated
Comment thread OpenDreamRuntime/Procs/DMProc.cs Outdated
Co-authored-by: wixoa <wixoag@gmail.com>
Comment thread OpenDreamRuntime/Procs/DMProc.cs Fixed
Comment thread OpenDreamRuntime/Objects/Types/DreamObjectCallee.cs Fixed
@tontyGH tontyGH requested a review from wixoaGit June 11, 2026 18:36
@wixoaGit wixoaGit merged commit 68bcf1d into OpenDreamProject:master Jun 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants