feat(stepup): add service display name to Stepup callout AuthnRequest#2034
Open
kayjoosten wants to merge 1 commit into
Open
feat(stepup): add service display name to Stepup callout AuthnRequest#2034kayjoosten wants to merge 1 commit into
kayjoosten wants to merge 1 commit into
Conversation
kayjoosten
force-pushed
the
feature/issue-2011-stepup-display-name
branch
from
4c29f14 to
b0887cb
Compare
Why is this change needed? Prior to this change, the Stepup Gateway SFO callout AuthnRequest contained no service name, so Stepup showed a generic proxy name in its 2FA UI instead of the actual application the user was logging in to. How does it address the issue? This change adds an mdui:UIInfo/mdui:DisplayName element to the samlp:Extensions of the callout AuthnRequest, using the user's current engine locale with an English fallback. The feature is controlled by the eb.stepup.send_service_name flag (disabled by default). Refs #2011
kayjoosten
force-pushed
the
feature/issue-2011-stepup-display-name
branch
from
b0887cb to
168d03d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mdui:UIInfo/mdui:DisplayNameto<samlp:Extensions>of the Stepup Gateway SFO callout AuthnRequest, so Stepup can surface the correct service name in its 2FA UI instead of the generic proxy nameeb.stepup.send_service_name(disabled by default)name*fieldsTechnical notes
StepupServiceNameExtensionclass insrc/OpenConext/EngineBlock/Stepup/follows the same pattern asStepupGsspUserAttributeExtensionxml:langattribute set viasetAttributeNS(XML namespace) so XPath and SAML consumers resolve it correctlyLocaleProvider::getLocale()available throughDiContainerTest plan
StepupServiceNameExtensionTest)Stepup.feature(includes 2 new scenarios: feature enabled / disabled)phpcsanddocheaderclean on new files