feat(feedback): show bookmark error page for saved WAYF URLs#2026
Open
kayjoosten wants to merge 2 commits into
Open
feat(feedback): show bookmark error page for saved WAYF URLs#2026kayjoosten wants to merge 2 commits into
kayjoosten wants to merge 2 commits into
Conversation
kayjoosten
force-pushed
the
feature/issue-1976-bookmark-error-page
branch
from
a4c62fc to
7d74bcf
Compare
kayjoosten
force-pushed
the
feature/issue-1976-bookmark-error-page
branch
3 times, most recently
from
8ca61f7 to
e27ca28
Compare
When the hide_bookmarkable_url feature is enabled, JS replaces the WAYF URL (containing SAMLRequest) with ?feedback=bookmark via history.replaceState. Visiting that bookmarked URL now shows a dedicated error page instead of a generic missing-parameter error. - Add bookmarked-page feedback route and error page - Gate hideBookmarkableUrl JSON config value behind eb.hide_bookmarkable_url flag - Handle ?feedback=bookmark redirect in singleSignOnAction before SAML validation (replaces smelly exception-listener query-param inspection) - Wire Wayf Twig extension to FunctionalTestingFeatureConfiguration in ci env - Add Behat scenarios covering the bookmark redirect and flag toggling Closes #1976
kayjoosten
force-pushed
the
feature/issue-1976-bookmark-error-page
branch
from
e27ca28 to
c6b103f
Compare
johanib
reviewed
Jun 23, 2026
kayjoosten
force-pushed
the
feature/issue-1976-bookmark-error-page
branch
from
c6b103f to
066c2cf
Compare
johanib
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/authentication/feedback/bookmarked-pageroute toFeedbackControllerRedirectToFeedbackPageExceptionListenerdetects?feedback=bookmarkon aMissingParameterExceptionand redirects to the new route instead of the generic "no authentication request received" pageContext
Follow-up of #1973 / PR #1987. When
eb.hide_bookmarkable_urlis enabled, the JS replaces?SAMLRequest=…with?feedback=bookmarkin the address bar. If the user bookmarks that URL and revisits it, they now see a specific, user-friendly error instead of a generic one.Closes #1976
Test plan
phpunit --testsuite=unit)HideBookmarkableUrl.featurepasses/authentication/idp/single-sign-on?feedback=bookmark→ redirects to/authentication/feedback/bookmarked-page→ shows "This page no longer exists"