Skip to content

DEP: set a temporary upper bound to coverage (<7.14.0) #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neutrinoceros wants to merge 4 commits into from
Closed

DEP: set a temporary upper bound to coverage (<7.14.0) #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
226e14b
DEP: set a temporary upper bound to coverage (`<7.14.0`)
neutrinoceros Jul 24, 2026
6505da6
try uv run instead of uvx
neutrinoceros Jul 24, 2026
83fa530
fixup! try uv run instead of uvx
neutrinoceros Jul 24, 2026
1b19b04
fixup! fixup! try uv run instead of uvx
neutrinoceros Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,13 +281,13 @@ jobs:
with:
paths: "**/results.xml"

- name: Combine converage reports for Codecov
- name: Combine coverage reports for Codecov
# Even if tox fails, upload coverage
if: ${{ (success() || failure()) && contains(matrix.coverage, 'codecov') && matrix.pytest == 'true' }}
# If there's not multiple files to combine then this will error but that's ok
continue-on-error: true
run: |
uvx coverage combine
uv run --group covcheck coverage combine

- name: Generate xml report for Codecov
# Even if tox fails, upload coverage
Expand All @@ -296,7 +296,7 @@ jobs:
if [ ! -f ".coverage" ]; then
echo "::error title=Misconfigured coverage reporting::No .coverage file was found in the root directory, this is now a requirement for uploading coverage to Codecov. See the documentation for more information: https://github-actions-workflows.openastronomy.org/en/stable/tox.html#coverage"
fi
uvx coverage xml -i
uv run --group covcheck coverage xml -i

- name: Upload to Codecov
# Even if tox fails, upload coverage
Expand Down Expand Up @@ -346,10 +346,10 @@ jobs:

- name: Combine Coverage
continue-on-error: true
run: uvx coverage combine
run: uv run --group covcheck coverage combine

- name: Combine Coverage
run: uvx coverage report -i -m --format=markdown >> $GITHUB_STEP_SUMMARY
run: uv run --group covcheck coverage report -i -m --format=markdown >> $GITHUB_STEP_SUMMARY

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency = [
]
covcheck = [
"coverage[toml] ; python_version < '3.11'",
"coverage>=7.11.3",
"coverage>=7.11.3, <7.14.0",
"pytest-cov>=7.0.0",
]
test = [
Expand Down
Loading