ci: correct the stale version comment on the pypi-publish pin - #43
Merged
Conversation
The pinned SHA dc37677b2e1c63e2034f94d8a5b11f265b73ba33 is v1.14.2, but the trailing comment still read `# release/v1`. That is the tag the pin replaced, so the comment described the wrong thing and made the pin look unpinned during an org-wide audit. The SHA does not change. This corrects the comment only, so it cannot alter release behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pin is already correct —
dc37677b2e1c63e2034f94d8a5b11f265b73ba33is v1.14.2. But the trailing comment still read# release/v1, which is the floating tag the SHA replaced:So the comment described the wrong thing. During an org-wide audit of this action, that mislabel made a correctly-pinned workflow read as unpinned, and it hides which version an incident review is actually looking at.
Fix
Correct the comment to
# v1.14.2.The SHA does not change. This is a comment-only edit and cannot alter release behaviour.
Verification
Tag resolved against upstream:
v1.14.2→dc37677b2e1c63e2034f94d8a5b11f265b73ba33, confirming the existing SHA and the new comment agree. The workflow still parses as valid YAML.No release is cut
The title is
ci:, andpatch_tagsis["fix", "perf"]— so this merges without cutting a release.🤖 Generated with Claude Code