ci: don't let a push cancel a release-qualification dispatch - #466
Merged
Conversation
The concurrency group keyed on workflow and ref only, so an ordinary push to main cancelled the workflow_dispatch run the release gate reads. That matrix takes about 50 minutes and merges to main land every 30, so qualifying main was a race the release could not win: 1.35.0 has now lost it twice, once at 50 minutes. Including github.event_name separates the two. Pushes still cancel pushes, and a second dispatch still cancels the first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/check_release_ci.pyrequires the latest exact-SHAworkflow_dispatchrun ofci.ymlto concludesuccess. The concurrency group wasci-${{ github.workflow }}-${{ github.ref }}, so any push tomaincancelled that dispatched run.The matrix takes about 50 minutes. Merges to
mainhave been landing every 30. Release 1.35.0 has now failed to qualify twice for this reason: run33815444477at2c89b27b, and run33816838747at491fc79e, which was cancelled at 50 minutes by the merge of39e68954.Adding
github.event_nameto the group separates dispatched runs from pushes. A push still cancels a superseded push, and a second dispatch still cancels the first, so nothing runs twice to completion.public-artifacts.jsonis regenerated in the same commit withpython scripts/check_release_consistency.py --write-public-artifact-inventory; the only change is theci.ymldigest.tests/test_ci_workflow_contract.pypasses.Opened by an agent session, not the founder.
🤖 Generated with Claude Code