fix: require passing evidence for supported claims - #368
Closed
abrichr wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a stacked draft PR. It depends on #367 and targets its branch so the review contains only the claims-evidence change.
A
supportedclaim no longer passes because a cited test file exists. The required CI job must supply real JUnit evidence that each cited file ran and passed.Root cause
The former gate had four fail-open paths:
--junitwas optional;fileattribute that Pytest xUnit2 does not emit, so real Pytest output could produce an empty status map.Change
testjob emits unit JUnit and validates unit-backed claims.e2e-browserjob emits browser JUnit and validates browser-backed claims.This reuses the existing required test executions. It does not add a duplicate test suite or a new expensive CI job.
Validation
actionlint: passed.git diff --check: passed.Stack
After #367 merges, retarget or rebase this PR onto
main. Do not merge this PR first.