test: pin the writer shutdown-drain contract - #85
Merged
Conversation
Pin the drain invariants that close the historical event-loss race at shutdown: a writer released while events remain buffered commits every one; a terminate racing the drain keeps the tail; releasing writers only after producers exit commits the whole stream; an empty queue exits promptly instead of hanging; and a failing write surfaces loudly instead of exiting clean. The drain contract is queue semantics plus loop ordering, so the writer runs against real SQLite in threads; the cross-process reconciliation is pinned by tests/test_control.py and re-proved live per OS by the production qualification trials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the event-loss-race-at-shutdown verification gap (state doc item 3): the ordering fix and reconciliation landed in #79, but the underlying writer drain invariants had no regression coverage.
Pins, against real SQLite via the real
write_eventsloop:The drain contract is queue semantics plus loop ordering, so writers run in threads; cross-process reconciliation stays pinned by tests/test_control.py and is re-proved live per OS by the qualification trials. No display, listeners, or input injection needed — runs on every PR leg.
Test evidence
5 new tests; full fast suite locally: 454 passed, 2 skipped; ruff clean.