[csharp][generichost] Refactor duplicate apis#24273
Open
devhl-labs wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor refactor only because this edge case is interfering in another change I want to make. I'm not sure why the api spec having tags results in duplicate apis, I'd like to see that removed. But until then we can just do this refactor.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Refactored the C# GenericHost templates to always generate unique ApiResponse types when tags create duplicate APIs. Response interfaces/classes are now prefixed with the API classname and used consistently across method signatures, events, logging, and constructors.
Refactors
api.mustache, usevendorExtensions.x-duplicateswith template lambdas to prefix ApiResponse interface/class names with the API classname, and propagate to return types (includingOrDefault), eventExecuteOn*signatures, logger generics, and response construction.IAPIKeysApiGetApiKeysIdApiResponse/APIKeysApiGetApiKeysIdApiResponseandIApiKeysApiGetApiKeysIdApiResponse/ApiKeysApiGetApiKeysIdApiResponse.Migration
IGetApiKeysIdApiResponse→IAPIKeysApiGetApiKeysIdApiResponse).Written for commit df29ada. Summary will update on new commits.