[Java] [Spring Client] Add an exception provider interface to allow for exception redefinition#23878
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
Conversation
…or easy exception redefinition
Contributor
There was a problem hiding this comment.
7 issues found across 70 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have scenarios where I want to have more fine-grained control over the exceptions that an ApiClient can throw. This so that I can handle them more properly by distinguishing them by type and decorating messages. Doing this with the current structure is cumbersome since the same exceptions are redefined in several places, and they are strongly coupled to the enormous
ApiClient.mustache. So I have to customize the base mustache to adjust this behavior.In order to decouple the exception handling and provider better control over it, I suggest that it is extracted into an
ExceptionProvider. This retains the current behavior of the exceptions thrown currently, but it also provides an extension point where these can be easily configured as a separate concept. Either with theExceptionProvider.mustache, or by injecting an extended interface into theApiClient.This approach is currently tailored towards Spring's
RestClientandWebClientonly.RestTemplateis intentionally omitted, since it is deprecated.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
Summary by cubic
Adds an
ExceptionProviderextension for SpringRestClientandWebClientJava clients to let users redefine thrown exceptions without touchingApiClient.mustache. Default behavior is unchanged and exception handling is now decoupled.New Features
ExceptionProvider.javafromExceptionProvider.mustacheforwebclientandrestclient.exceptionProviderfield with getter/setter in generatedApiClient; defaults toExceptionProvider.DEFAULT.JavaClientCodegento include the supporting file for these libraries.Migration
ExceptionProviderand callapiClient.setExceptionProvider(...).RestClientandWebClientonly;RestTemplateis not included.Written for commit 8f01653. Summary will update on new commits. Review in cubic