Add package version for python fastapi to be inline with openapi gene…#21609
Add package version for python fastapi to be inline with openapi gene…#21609Goopher wants to merge 1 commit into
Conversation
|
|
||
| if (additionalProperties.containsKey(CodegenConstants.PACKAGE_VERSION)) { | ||
| setPackageVersion((String) additionalProperties.get(CodegenConstants.PACKAGE_VERSION)); | ||
| } |
There was a problem hiding this comment.
what about adding a else to set the default of packageVersion to appVersion for backward compatibility?
There was a problem hiding this comment.
The package version is always set to default "1.0.0" as is in line with the documentation at https://openapi-generator.tech/docs/generators/python-fastapi/
Falling back to appVersion isn't necessary and not in line with other generators as well.
There was a problem hiding this comment.
appVersion is obtained from (or default to) the value in the spec: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml#L8
|
looks like a rebase failed can you please file a new PR based on the latest master? we will continue there to get try to get it merged before upcoming release |
a6f82ef to
f73ea73
Compare
|
closed via #23766 (you as co-author) |
…rator docs
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@multani @cbornet @tomplus @krjakbrjak @fa0311