Skip to content

[client] chore(merge): add null checks for backwards compatibilty (#243)#244

Merged
antoinemzs merged 3 commits into
mainfrom
fix/null_check_2
May 18, 2026
Merged

[client] chore(merge): add null checks for backwards compatibilty (#243)#244
antoinemzs merged 3 commits into
mainfrom
fix/null_check_2

Conversation

@antoinemzs
Copy link
Copy Markdown
Member

Close #243

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@github-actions github-actions Bot added the filigran team use to identify PR from the Filigran team label May 18, 2026
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Copy link
Copy Markdown
Member

@guzmud guzmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.34%. Comparing base (4b32065) to head (40a738b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyoaev/configuration/sources.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   70.36%   70.34%   -0.03%     
==========================================
  Files          49       49              
  Lines        1964     1966       +2     
==========================================
+ Hits         1382     1383       +1     
- Misses        582      583       +1     
Flag Coverage Δ
connectors 70.34% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antoinemzs antoinemzs merged commit d175c7f into main May 18, 2026
12 checks passed
@antoinemzs antoinemzs deleted the fix/null_check_2 branch May 18, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration objects crash process when passed nullable setting with None value

3 participants