Merge Dev to Beta

[Jordonbc]

No description provided.

[github-actions]

PR Review: Dev → Beta

Summary

This PR makes significant architectural changes across frontend and backend, primarily:

1. Removes TAURI.has guard pattern - Replaces with proper runtime assertions and error handling
2. Refactors plugin runtime - Better error reporting for disconnects, poisoned mutex handling
3. Commit identity - Now fails fast when Git has no identity instead of inventing defaults
4. Code cleanup - Removes dead/duplicate code, simplifies stash interactions

Issues Found

Bug (Frontend/src/scripts/features/repo/stash.ts):
Lines 80, 88, 193, 206, 221 have blank lines after try {:

items.push({ label: 'Apply stash', action: async () => {
    try {
        
        await TAURI.invoke('git_stash_apply', { selector: target });

These empty lines should be removed - they're leftover artifacts from removing if (!TAURI.has).

Bug (Backend/src/tauri_commands/commit.rs):
The commit_patch_and_files function at line 242-243 has inconsistent doc comments - files is described as "Explicit commit path list" but the code at line 286 still uses stage_paths for staging when files is provided. The stage_paths parameter should only be used when files are NOT in the patch.

Code Quality:

• Backend/src/state.rs: Removed repo_config() method - verify no callers elsewhere.
• Frontend/src/scripts/lib/tauri.ts:47-49: listen() returns a rejected promise when tEvent is null, but many call sites use TAURI.listen?.(...) optional chaining expecting it to be safe - this changes behavior.

Test Results

• Frontend tests: 26/26 passed

Recommendations

1. Fix the blank-line artifacts in stash.ts
2. Verify commit_patch_and_files staging logic handles the patch+files case correctly
3. Document the TAURI.listen behavioral change for callers using optional chaining

opencode session  |  github run

[github-actions]

PR Review Summary

Based on my review of the changes:

Issues Investigated

1. Blank lines in stash.ts - The file is clean. No blank lines after try { exist in current code. This appears to have been fixed already.

2. commit_patch_and_files staging logic - The code at lines 283-297 in Backend/src/tauri_commands/commit.rs correctly handles the logic:

   • Stages stage_paths if provided (lines 283-292)
   • Uses files for commit when provided (lines 293-304)
   • The behavior matches the doc comment description.

3. TAURI.listen behavioral change - The change from no-op to throwing an error (lines 43-47 in tauri.ts) is a breaking change for 10 call sites using optional chaining TAURI.listen?.(...). These callers expected silent failure but now get a thrown error. This may cause crashes in non-Tauri environments.

4. repo_config() removal - No callers exist in codebase. Safe to remove.

Test Results

• Frontend tests: 26/26 passed ✓
• TypeScript type-check: Passed ✓
• Rust formatting: N/A (missing system libs in test env)

Recommendation

The PR looks good. The main concern is the TAURI.listen behavioral change - callers using TAURI.listen?.(...) expect silent failure but now get an exception. Consider either:

1. Documenting this as a breaking change
2. Making listen return a no-op Promise when runtime unavailable

No code edits needed - tests pass.

opencode session  |  github run