Update beta

[Jordonbc]

No description provided.

[opencode-agent]

Based on my review of this pull request (45 commits, 56 files changed), here's my analysis:

Code Review Summary

Code Quality Issues

1. Backend/src/monitoring.rs:355 - Uses .expect() which can panic in production:

   .expect("stacktrace expected");

   Should use proper error handling with ? operator or ok_or() pattern.

2. Backend/src/validate.rs:54,79 - Regex patterns are compiled on every invocation:

   let scp_like = regex::Regex::new(r"^[\w.-]+@[\w.-]+:[\w./-]+\.git$").unwrap();

   Consider moving to module-level lazy statics.

3. Frontend/src/scripts/lib/monitoring.ts:145 - Array splice for trimming can be inefficient:

   frontendBreadcrumbs.splice(0, frontendBreadcrumbs.length - MAX_FRONTEND_BREADCRUMBS);

   Consider a ring buffer implementation for better performance at scale.

Potential Bugs

1. Frontend/src/scripts/main.ts:388-400 - Plugin menu action handler:

   case '__plugin_menu_action__': {
       const pluginId = String(payload?.pluginId || '').trim();
       const actionId = String(payload?.actionId || '').trim();
       if (!pluginId || !actionId) break;

   Silently fails with no user feedback if IDs are empty after trim. ConsiderNotify() for better UX.

2. Backend/src/lib.rs:37-41 - Silent loading of .env file:

   fn load_local_dotenv() {
       let dotenv_path = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("../.env");
       let _ = dotenvy::from_path(&dotenv_path);
   }

   This silently swallows all errors - if the file exists but is malformed, the user won't know.

Suggestions for Improvement

1. Backend/src/lib.rs - Good error capture for startup failures via monitoring::capture_startup_error(), but consider adding structured error codes for easier debugging.

2. Frontend/src/scripts/lib/logger.ts:90 - The logger patching pattern is good, but console.info handling duplicates logic with console.log - consider extracting common formatting.

3. Frontend/src/scripts/main.ts - Mixed async patterns (void Promise.allSettled vs await Promise.allSettled) at lines 194 and 217 make error handling inconsistent. Standardize to one pattern.

4. Workflow files - Several workflow files have very similar changes (beta.yml, nightly.yml). Consider extracting common job definitions to a reusable workflow.

Positives

• Comprehensive Sentry integration adds valuable crash reporting
• Plugin update channels properly implemented
• Tests pass (26/26 in Frontend)
• Good use of lazy initialization for monitoring breadcrumbs
• Proper separation between frontend/backend monitoring concerns
• Config watcher adds nice DX improvement

Recommendation: Address the .expect() in monitoring.rs before merging - that's the highest-priority issue.

opencode session  |  github run

[opencode-agent]

User opencode-agent[bot] does not have write permissions

github run

[opencode-agent]

User opencode-agent[bot] does not have write permissions

github run

[opencode-agent]

Code Review Summary

Code Quality Issues

1. Backend/src/validate.rs:54,79 - Regex patterns are compiled on every invocation:

   let scp_like = regex::Regex::new(r"^[\w.-]+@[\w.-]+:[\w./-]+\.git$").unwrap();

   Should be moved to module-level lazy statics for performance.

2. Backend/src/monitoring.rs:355 - Uses .expect() in test:

   .expect("stacktrace expected");

   Acceptable in tests but error message is generic.

Potential Bugs

1. Frontend/src/scripts/main.ts:391-395 - Plugin menu action silently fails:

   const pluginId = String(payload?.pluginId || '').trim();
   const actionId = String(payload?.actionId || '').trim();
   if (!pluginId || !actionId) break;

   No user feedback when IDs are empty after trim - consider adding a notify() call.

2. Backend/src/lib.rs:41-44 - Silent .env loading swallows errors:

   fn load_local_dotenv() {
       let dotenv_path = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("../.env");
       let _ = dotenvy::from_path(&dotenv_path);
   }

   If the file exists but is malformed, users won't know. Consider logging a warning.

Suggestions for Improvement

1. Frontend/src/scripts/lib/monitoring.ts:102 - Array splice for trimming is acceptable but could use a ring buffer if scaling becomes an issue.

2. Frontend patterns - Mixed async patterns are consistent throughout this PR.

3. Test coverage - Good test coverage in monitoring.rs and Frontend tests. Tests pass (26/26 in Frontend).

Positives

• Clean Sentry integration with proper frontend/backend relay
• Good plugin update channel implementation
• Comprehensive test coverage
• Well-documented code with proper doc comments
• Config watcher adds good DX improvement

Recommendation: Priority fix is the .expect() in monitoring.rs:355 if it can receive invalid input in production scenarios. Regex statics in validate.rs are a nice-to-have optimization.

opencode session  |  github run

[opencode-agent]

Based on my review of the key files, here's my analysis:

Code Review

Previous Issues - Status Check

The prior reviews identified several issues. Let me verify their status:

1. Backend/src/monitoring.rs:355 - .expect("stacktrace expected") - This is in a #[cfg(test)] module (line 340-341), so it's acceptable. Tests can use expect.

2. Backend/src/validate.rs:54,79 - Regex patterns compiled per invocation - Already fixed. Lines 7-12 now use LazyLock:

   static SCP_LIKE_RE: Lazy

opencode session  |  github run

[opencode-agent]

Code Review Summary

Based on my review of the current state, most prior issues have been addressed:

Fixed Issues ✅

1. Backend/src/validate.rs:7-12 - Regex patterns now use LazyLock (already optimized)
2. Backend/src/monitoring.rs:355 - .expect() is only in test code (#[cfg(test)] module), which is acceptable
3. Backend/src/lib.rs:47-56 - Now has proper error logging with eprintln! for malformed .env files
4. Frontend/src/scripts/main.ts:396-402 - Now provides user feedback via notify() for missing plugin/action IDs

Remaining Minor Issues

1. Frontend/src/scripts/lib/monitoring.ts:145 - Array splice at scale:

   frontendBreadcrumbs.splice(0, frontendBreadcrumbs.length - MAX_FRONTEND_BREADCRUMBS);

   This is fine for typical usage but could use a ring buffer if breadcrumbs grow large.

2. Workflow duplication - .github/workflows/beta.yml and .github/workflows/nightly.yml have nearly identical changes. Consider a reusable workflow.

No Issues Found

• Regex compilation: ✅ Fixed
• .expect() in production: ✅ Not applicable (test only)
• Silent .env failures: ✅ Fixed
• Silent plugin action failures: ✅ Fixed

Positives

• Clean Sentry integration with proper frontend/backend relay
• Comprehensive test coverage (tests passing)
• Good error handling patterns throughout
• Proper doc comments on public APIs

Recommendation: This PR is ready to merge. The remaining suggestions are minor optimizations, not blockers.

opencode session  |  github run

[opencode-agent]

Code Review Summary

Based on my review of this PR (51 commits, 62 files changed), here's my analysis:

Prior Issues - Status

Issue	Status
Regex patterns in validate.rs compiled per invocation	✅ Fixed - Now uses LazyLock (lines 7-12)
.expect() in monitoring.rs:355	✅ Acceptable - Only in #[cfg(test)] module
Silent .env loading	✅ Fixed - Now logs via eprintln! (lines 51-56)
Silent plugin menu action failures	✅ Fixed - Now calls notify() with specific error (lines 396-402)

Code Quality

1. Backend/src/validate.rs - Clean implementation with module-level regex statics. Good doc comments.
2. Backend/src/monitoring.rs - New file with comprehensive Sentry integration. Proper #[cfg(test)] boundary.
3. Frontend/src/scripts/main.ts:391-409 - Plugin action handling now provides specific user feedback instead of silent failure.

Remaining Minor Suggestions

1. Frontend/src/scripts/lib/monitoring.ts:101-102 - Array splice:

   if (frontendBreadcrumbs.length > MAX_FRONTEND_BREADCRUMBS) {
     frontendBreadcrumbs.splice(0, frontendBreadcrumbs.length - MAX_FRONTEND_BREADCRUMBS);
   }

   Fine for current limits (40 items). Ring buffer is a future optimization if scaling needed.

2. Workflow files - beta.yml and nightly.yml have similar structure. Consider reusable workflow for DRY if more workflows are planned.

No Issues Found

• Regex compilation: ✅ Optimized
• Error handling: ✅ Proper patterns throughout
• Test coverage: ✅ New tests added for monitoring and settings
• Documentation: ✅ Doc comments on public APIs

Positives

• Comprehensive Sentry integration (backend + frontend relay)
• Plugin update channels properly implemented
• New settings modal with General tab (settingsGeneral.ts, settingsGeneral.test.ts)
• Confirm modal for destructive actions (confirmModal.ts)
• Good error UX with specific notify() messages for missing IDs

Recommendation: This PR is ready to merge. All prior blocking issues have been addressed.

opencode session  |  github run

[opencode-agent]

Code Review Summary

Based on my review of the key files in this PR (62 files, 51 commits):

✅ Issues Already Fixed

Issue	Location	Status
Regex patterns compiled per call	Backend/src/validate.rs:7-12	✅ Fixed - uses LazyLock
Silent .env loading	Backend/src/lib.rs:47-57	✅ Fixed - logs via eprintln!
Silent plugin action failures	Frontend/src/scripts/main.ts:395-402	✅ Fixed - specific notify() messages
.expect() in test code	Backend/src/monitoring.rs:355	✅ Acceptable - only in #[cfg(test)]

Code Quality - No Issues Found

• Regex compilation: Optimized with module-level LazyLock statics
• Error handling: Proper patterns throughout (notify, eprintln, log::warn)
• Test coverage: New tests in monitoring.rs and settingsGeneral.test.ts
• Documentation: Doc comments on public APIs per conventions

Remaining Minor Suggestions

1. Frontend/src/scripts/lib/monitoring.ts:101-102 - Array splice for breadcrumb trimming:

   frontendBreadcrumbs.splice(0, frontendBreadcrumbs.length - MAX_FRONTEND_BREADCRUMBS);

   Fine for current limits (40 items). Ring buffer is a future optimization if needed at scale.

2. Workflow files - beta.yml and nightly.yml have similar structure. Consider reusable workflow if more similar workflows are planned.

Positives

• Clean Sentry integration with frontend/backend relay
• New settings modal with General tab (crash report toggle)
• Plugin update channels properly implemented
• Comprehensive error UX improvements
• Good test coverage for monitoring and settings

Recommendation: This PR is ready to merge. All prior blocking issues have been addressed. The remaining suggestions are minor optimizations, not blockers.

opencode session  |  github run