Skip to content

fix(deploy): use approved network diagnostics #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mustafazeydani merged 1 commit into from
Aug 19, 2026
Merged

fix(deploy): use approved network diagnostics #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devops/production/bin/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,9 @@ prepare_release() {
sync_runtime_env_from_infisical
ensure_private_directory "${ROOT_DIR}/data" 700
ensure_private_directory "${ROOT_DIR}/data/releases" 700
docker_cmd network inspect "${EDGE_NETWORK}" >/dev/null \
docker_cmd network-exists "${EDGE_NETWORK}" >/dev/null \
|| fail "External Docker network ${EDGE_NETWORK} is missing"
docker_cmd network inspect "${DATA_NETWORK}" >/dev/null \
docker_cmd network-exists "${DATA_NETWORK}" >/dev/null \
|| fail "External Docker network ${DATA_NETWORK} is missing"
docker_cmd inspect "${POSTGRES_CONTAINER}" >/dev/null \
|| fail "Shared PostgreSQL container is missing"
Expand Down
18 changes: 18 additions & 0 deletions devops/production/bin/test_production_deploy_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import unittest
from pathlib import Path


DEPLOY_SCRIPT = Path(__file__).with_name("deploy.sh")


class ProductionDeployContractTest(unittest.TestCase):
def test_uses_approved_network_diagnostics(self) -> None:
script = DEPLOY_SCRIPT.read_text(encoding="utf-8")

self.assertIn('docker_cmd network-exists "${EDGE_NETWORK}"', script)
self.assertIn('docker_cmd network-exists "${DATA_NETWORK}"', script)
self.assertNotIn("docker_cmd network inspect", script)


if __name__ == "__main__":
unittest.main()