Skip to content

Separate workflow reusable-call runs from standalone runs#2443

Merged
soumeh01 merged 2 commits intomainfrom
concurrency-overrun
Apr 17, 2026
Merged

Separate workflow reusable-call runs from standalone runs#2443
soumeh01 merged 2 commits intomainfrom
concurrency-overrun

Conversation

@soumeh01
Copy link
Copy Markdown
Contributor

@soumeh01 soumeh01 commented Apr 17, 2026

Changes

Fix concurrency collisions between scheduled and push-triggered workflows

Previously, workflows such as packchk, packgen, and projmgr etc used a concurrency group based only on ${{ github.workflow }}-${{ github.ref }}. This caused runs triggered by different events (e.g. nightly schedule vs. push to main) to share the same concurrency group and cancel each other when cancel-in-progress: true was set.

As a result, a scheduled nightly run could be unexpectedly cancelled by a push-triggered run. For e.g. https://github.com/Open-CMSIS-Pack/devtools/actions/runs/24540773684/attempts/1
This change updates the concurrency group to include ${{ github.event_name }}, ensuring that runs triggered by different event types are isolated:

${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@soumeh01 soumeh01 requested review from brondani and jkrech April 17, 2026 07:25
jkrech
jkrech previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

Test Results

  7 files   53 suites   5m 51s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 14e90c8.

♻️ This comment has been updated with latest results.

@soumeh01 soumeh01 merged commit 2b74841 into main Apr 17, 2026
120 checks passed
@soumeh01 soumeh01 deleted the concurrency-overrun branch April 17, 2026 10:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.75%. Comparing base (c2e5f7d) to head (14e90c8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2443   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files         145      145           
  Lines       26168    26168           
  Branches    15799    15799           
=======================================
  Hits        16946    16946           
  Misses       7066     7066           
  Partials     2156     2156           
Flag Coverage Δ
buildmgr-cov 79.87% <ø> (ø)
packchk-cov 69.75% <ø> (ø)
packgen-cov 82.02% <ø> (ø)
projmgr-cov 87.77% <ø> (ø)
svdconv-cov 40.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants