[projmgr] Accept listing same component multiple times in clayers#2441
[projmgr] Accept listing same component multiple times in clayers#2441
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates projmgr’s component conflict handling so that duplicate component listings coming from c-layers no longer fail processing, aligning with the need to tolerate repeated component references during layer-based conversions.
Changes:
- Downgrade “duplicate component” conflicts to warnings when duplicates originate from clayers (while keeping cproject duplicates as errors).
- Extend
ProjMgrWorker::AddComponentwith anignoreDuplicatesflag and use it for clayer-sourced components. - Update the unit test to validate the new error vs warning behavior across the two contexts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrWorker.cpp | Adds ignoreDuplicates handling for clayer component addition and logs a warning instead of failing on duplicates. |
| tools/projmgr/include/ProjMgrWorker.h | Updates AddComponent signature to include ignoreDuplicates (defaulting to false). |
| tools/projmgr/test/src/ProjMgrUnitTests.cpp | Adjusts DuplicateComponents test expectations: cproject duplicates still error, clayer duplicates now warn and succeed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 3 files 21 suites 14m 56s ⏱️ Results for commit a8143f3. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
- Coverage 64.75% 64.75% -0.01%
==========================================
Files 145 145
Lines 26168 26171 +3
Branches 15799 15801 +2
==========================================
Hits 16946 16946
- Misses 7066 7068 +2
- Partials 2156 2157 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Changes
warninginstead oferrorin this case)Checklist