Skip to content

Add the board-pack-path: and device-pack-path: in cbuild-run.yml#2440

Merged
brondani merged 4 commits intoOpen-CMSIS-Pack:mainfrom
jthuangarm:pack-cbuildRun
Apr 15, 2026
Merged

Add the board-pack-path: and device-pack-path: in cbuild-run.yml#2440
brondani merged 4 commits intoOpen-CMSIS-Pack:mainfrom
jthuangarm:pack-cbuildRun

Conversation

@jthuangarm
Copy link
Copy Markdown
Contributor

@jthuangarm jthuangarm commented Apr 15, 2026

Fixes

Changes

  • Add support for specifying local paths to board and device packs (e.g. board-pack-path and device-pack-path) in the cbuild-run.yml. The changes affect data structures, YAML parsing, schema validation, and test data.
  • Updated all relevant .cbuild-run.yml reference files

For example:
image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit board/device pack installation path fields to generated .cbuild-run.yml files, enabling downstream tools (debug/flash workflows) to reliably locate local packs that aren’t derivable from CMSIS_PACK_ROOT.

Changes:

  • Extend run/debug data model (RunDebugType) to carry boardPackPath / devicePackPath.
  • Emit new YAML keys board-pack-path / device-pack-path in .cbuild-run.yml generation and capture the values from selected packs.
  • Update JSON schema and refresh .cbuild-run.yml reference outputs used by tests.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/projmgr/src/ProjMgrRunDebug.cpp Captures absolute pack paths for device/board packs into the run/debug model.
tools/projmgr/src/ProjMgrCbuildRun.cpp Emits board-pack-path and device-pack-path into generated .cbuild-run.yml.
tools/projmgr/schemas/common.schema.json Extends schema to allow the new YAML properties.
tools/projmgr/include/ProjMgrYamlParser.h Adds YAML key constants for the new fields.
tools/projmgr/include/ProjMgrRunDebug.h Extends RunDebugType with new path members.
tools/projmgr/test/data//.cbuild-run.yml Updates reference .cbuild-run.yml outputs to include the new path fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/src/ProjMgrRunDebug.cpp
@jthuangarm jthuangarm marked this pull request as ready for review April 15, 2026 14:32
@jthuangarm jthuangarm requested a review from brondani April 15, 2026 14:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Test Results

    3 files     21 suites   18m 1s ⏱️
  456 tests   456 ✅ 0 💤 0 ❌
1 368 runs  1 368 ✅ 0 💤 0 ❌

Results for commit ef5e6c2.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit c2e5f7d into Open-CMSIS-Pack:main Apr 15, 2026
54 of 56 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.75%. Comparing base (f74c516) to head (ef5e6c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrCbuildRun.cpp 75.00% 0 Missing and 1 partial ⚠️
tools/projmgr/src/ProjMgrRunDebug.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files         145      145           
  Lines       26161    26168    +7     
  Branches    15792    15799    +7     
=======================================
+ Hits        16941    16946    +5     
  Misses       7063     7063           
- Partials     2157     2159    +2     
Flag Coverage Δ
projmgr-cov 87.77% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrRunDebug.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildRun.cpp 95.08% <75.00%> (-0.34%) ⬇️
tools/projmgr/src/ProjMgrRunDebug.cpp 87.50% <75.00%> (-0.13%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jthuangarm jthuangarm deleted the pack-cbuildRun branch April 15, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants