Add default attribute to memory in cbuild-run.yml#2438
Add default attribute to memory in cbuild-run.yml#2438brondani merged 3 commits intoOpen-CMSIS-Pack:mainfrom
default attribute to memory in cbuild-run.yml#2438Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for exposing the CMSIS-Pack default attribute on memory regions in generated .cbuild-run.yml output, enabling downstream tools (e.g., pyOCD RTT search) to identify “general-purpose” default memory.
Changes:
- Extend the projmgr common JSON schema to allow a new boolean
defaultproperty onsystem-resources: memoryentries. - Collect the
defaultattribute from pack memory definitions during run/debug settings collection. - Emit
default: trueinto generated.cbuild-run.ymlreference outputs for default memory regions.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/projmgr/include/ProjMgrRunDebug.h | Adds an optional flag to represent whether a memory region is marked as default. |
| tools/projmgr/src/ProjMgrRunDebug.cpp | Reads the pack memory default attribute into the collected run/debug model. |
| tools/projmgr/src/ProjMgrCbuildRun.cpp | Writes the optional default flag into the generated YAML system-resources.memory nodes. |
| tools/projmgr/schemas/common.schema.json | Defines default as a supported boolean property for system memory objects. |
| tools/projmgr/test/data//.cbuild-run.yml | Updates expected YAML outputs to include default: true on default memory regions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 3 files 21 suites 15m 58s ⏱️ Results for commit b79d0ed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
=======================================
Coverage 64.75% 64.75%
=======================================
Files 145 145
Lines 26157 26161 +4
Branches 15788 15792 +4
=======================================
+ Hits 16937 16941 +4
Misses 7063 7063
Partials 2157 2157
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
To address #2424
This pull request introduces support for marking memory regions as
defaultin the project manager tool. In cbuild-run.ymldefaultis located right before thefrom-pack:property undermemory.common.schema.json) to define the newdefaultproperty for memory objects.ProjMgrRunDebug.cppto read thedefaultattribute when collecting settings and to write it when generating YAML output.