Refine discoverLayer errMsg#2430
Merged
brondani merged 2 commits intoOpen-CMSIS-Pack:mainfrom Apr 8, 2026
Merged
Conversation
Test Results456 tests 456 ✅ 9m 48s ⏱️ Results for commit bcfb8bc. ♻️ This comment has been updated with latest results. |
Contributor
Author
brondani
reviewed
Apr 8, 2026
Collaborator
brondani
left a comment
brondani
left a comment
There was a problem hiding this comment.
I agree with the proposed refinement.
For consistency I suggest to use single quotes instead of double quotes, and I believe a line break \n is needed for correct visualization of the message in two lines.
brondani
approved these changes
Apr 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
=======================================
Coverage 64.73% 64.73%
=======================================
Files 145 145
Lines 26147 26147
Branches 15783 15783
=======================================
Hits 16927 16927
Misses 7066 7066
Partials 2154 2154
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address: Open-CMSIS-Pack/vscode-cmsis-solution#119
Updates the error message shown when no compatible software layer is found.
User-facing improvements:
ProjMgrRpcServer.cppto clarify that no compatible software layer was found in the installed packs and to instruct users to install additional packs before restarting the "Create Solution" flow.Testing updates:
ProjMgrRpcTests.cppto expect the new, more descriptive error message.