ci: call the reusable release-please workflow - #4
Merged
Conversation
The inline job existed because the reusable one forwarded none of the action's outputs, and the publish job is gated on release_created. OneLiteFeatherNET/workflows#21 added them, released as v2.5.0, so the last inline piece of CI can go. All pins move to v2.5.0 in the same step, so every workflow in this repository references one version of the shared catalogue. The permissions block stays on the caller: a called workflow never holds more permissions than the calling one, so dropping contents/pull-requests write here would leave release-please unable to open its release PR. Checked against the tag rather than assumed: v2.5.0 exports release_created, and gradle-publish.yml@v2.5.0 still accepts java-version and java-distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the last inline job in CI with the shared workflow, now that it can carry the gating output.
Why this was blocked
release-please.ymlforwarded none of the action's outputs, while the publish job is gated on:Switching over before that was fixed would have left the condition permanently false — releases tagged, nothing published. OneLiteFeatherNET/workflows#21 added the outputs and shipped as
v2.5.0.Changes
release-please.yamlcallsrelease-please.yml@v2.5.0instead of runninggoogleapis/release-please-action@v5inline.v2.5.0, so every workflow here points at one version of the shared catalogue.permissionsblock stays on the caller — a called workflow never holds more permissions than the calling one, so removingcontents: write/pull-requests: writewould leave release-please unable to open its release PR.Verified
Against the tag, not assumed:
release-please.yml@v2.5.0exportsrelease_created— the only output this workflow consumes.gradle-publish.yml@v2.5.0still acceptsjava-versionandjava-distribution.No behaviour change intended: same trigger, same gating, same publish inputs.