fix(renovate): shorten the otel depname so bumps pass commitlint - #112
Open
TheMeinerLP wants to merge 1 commit into
Open
fix(renovate): shorten the otel depname so bumps pass commitlint#112TheMeinerLP wants to merge 1 commit into
TheMeinerLP wants to merge 1 commit into
Conversation
PR #89 cannot be merged and never could: Renovate generates chore(deps): update ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java docker tag to v2.30.0 which is 112 characters against the 100-character header-max-length this repo enforces via commitlint. Every future bump of that image fails the same way, so re-running CI cannot fix it. Measured across the repo, the message format leaves roughly 57 characters for the depName, and exactly one image exceeds it — this one, at 70. A targeted overrideDepName is therefore proportionate; a generic registry-stripping rule would not even help, since dropping "ghcr.io/" still leaves 62. Result: 71 characters. Renovate will close #89 and open a replacement, because overrideDepName also changes the branch name. That is the intended mechanism, not a side effect — the new PR is compliant from the start. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HzZ7or95EosGNvwceYV5UA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the root cause behind #89.
The failure
Renovate generates:
112 characters against the 100-character limit this repo enforces in
commitlint.config.mjs. Re-running CI cannot fix #89 — and every future bumpof that image would fail identically.
Why a targeted rule rather than a generic one
The message format is
chore(deps): update <depName> docker tag to <version>, whichleaves roughly 57 characters for the depName. I scanned every registry image
reference in
apps/,infrastructure/andhelm/:ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-javaExactly one of seven exceeds the budget. A generic registry-stripping rule would
not even solve it — dropping
ghcr.io/still leaves 62 characters.Result
overrideDepNameis the documented option for this (Renovate config docs, underpackageRules). Only the display name changes — the image, datasource and versionresolution are untouched.
What happens to #89
overrideDepNamealso changes the branch name, so Renovate will close #89 andopen a replacement that is compliant from the start. That is the intended
mechanism, not a side effect — there is nothing to salvage in the existing branch.
Not included
This repo's
renovate.jsondoes not extend OneLiteFeather's central preset(
github>OneLiteFeatherNET/renovate:default(<team>)), which the org standardcalls for. Migrating would also bring reviewer assignment, office-hours
scheduling and patch automerge — but it requires choosing the responsible team,
which is not my call. Worth a separate PR.
./scripts/validate.shexits 0;renovate.jsonparses.🤖 Generated with Claude Code
https://claude.ai/code/session_01HzZ7or95EosGNvwceYV5UA