test: increase coverage - #99
Merged
Merged
Conversation
The module-level PIL/tkinter import made every module importing util_functions (including Floor/Generator) fail on systems without the Tk system library, blocking headless usage and testing of the generation logic. Moved it into the only function that needs it.
generator_test.py previously only had a setUp with no actual test cases, leaving the core dungeon-generation algorithm untested. Adds tests for start/boss room placement, floor bounds, unique room coordinates, full reachability (including teleport-room links), seed determinism, dead-end marking, special room assignment, and JSON serialization/round-trip/save behavior.
…eneration Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply