Skip to content

refactor: introduce event-driven page completion handling#82

Open
theEvilReaper wants to merge 8 commits intomainfrom
rework/pageFinish
Open

refactor: introduce event-driven page completion handling#82
theEvilReaper wants to merge 8 commits intomainfrom
rework/pageFinish

Conversation

@theEvilReaper
Copy link
Copy Markdown
Contributor

Proposed changes

This pull request overhauls how the game handles the case where all pages are found. An event is now fired instead of relying on method references, and the old approach has been removed

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@theEvilReaper theEvilReaper self-assigned this May 7, 2026
@theEvilReaper theEvilReaper added the area: game Everything related to the the game module label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant