docs(specs): add speckit tasks for 4 refactored core subsystems - #127
Open
TheMeinerLP wants to merge 6 commits into
Open
docs(specs): add speckit tasks for 4 refactored core subsystems#127TheMeinerLP wants to merge 6 commits into
TheMeinerLP wants to merge 6 commits into
Conversation
/speckit-tasks output for 001-elo-engine, 002-punishment-core, 003-appeal-workflow, and 006-player-reports — the four subsystems whose Constitution Check FAIL/PARTIAL layering findings were already fixed by PR #121-#124. Each tasks.md documents the full user-story breakdown as a converge-able checklist, with a clear split between already-shipped work and genuinely outstanding items: - 001-elo-engine: 3 remaining (DTO/Error-variant + EloApi consolidation, quickstart re-validation) - 002-punishment-core: 6 remaining, including two real correctness gaps found during review (live template reference retroactively changes historical punishment display; deleting a referenced template throws an unhandled DB exception instead of failing cleanly) - 003-appeal-workflow: 3 remaining (this one converged furthest — PR #123 also covered the revokedBy audit stamp and race-window Javadoc I'd asked for as follow-ups) - 006-player-reports: 4 remaining (non-atomicity Javadoc, DTO/Error-variant + ReportApi consolidation, quickstart re-validation)
… task /speckit-converge found one gap: GET /appeal/ (AppealController.getAll) fully implements FR-019 but no task in tasks.md traced to it. Purely a task-list completeness gap from writing tasks.md, not a functional one - everything else (19 FRs, 7 SCs, 5 user stories, all 6 constitution principles) checked out clean against the actual code.
…g task /speckit-converge found one gap: plan.md's Technical Context flagged RedisTopology's hardcoded key/channel names as "worth flagging for /speckit-tasks" but no task in tasks.md ever addressed it. Re-verified both known correctness bugs (T028 live template reference, T029 FK-cascade delete) are still present and already correctly tracked - not re-flagged. All 13 FRs map to a task; no coverage gaps otherwise.
Verified T001-T020 were already shipped; /speckit-implement closed T021 (non-atomicity Javadoc) and T023 (ReportApi extraction) in a companion code change. T022 (DTO/Error-variant consolidation, breaking wire-format risk) and T024 (full quickstart re-validation) deliberately left open.
Verified T001-T024 were already shipped. /speckit-implement closed T025 (race Javadoc), T027 (Api extraction), T029 (template-delete FK correctness fix), and T031 (RedisTopology config decision) in a companion code change. T026 (DTO/Error-variant consolidation) and T028 (schema-changing template snapshot) deliberately left open pending an explicit scoping decision.
Verified T001-T024 were already shipped. T028 (converge-appended GET /appeal/ traceability to FR-019) needed no code, closed on discovery. /speckit-implement closed T026 (AppealApi extraction) in a companion code change. T025 (DTO/Error-variant consolidation) and T027 (full quickstart re-validation) deliberately left open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/speckit-tasksoutput for001-elo-engine,002-punishment-core,003-appeal-workflow, and006-player-reports— the four subsystems whose Constitution Check FAIL/PARTIAL layering findings from PR chore(claude): add spec-kit tooling and retroactive specs for core subsystems #119 were already fixed by PR refactor(backend): extract EloQueryService methods for EloController reads #121–refactor(backend): extract ReportService from ReportController #124.tasks.mdis a full user-story-organized breakdown (per the/speckit-taskstemplate) that/speckit-convergecan check the code against, with an explicit up-front note distinguishing already-shipped tasks from genuinely outstanding ones — sinceplan.mdfor each predates the layering fixes and would otherwise read as more incomplete than the code actually is.Remaining work surfaced per subsystem:
001-elo-engine: 3 tasks (DTO/Error-variant +EloApiconsolidation, quickstart re-validation)002-punishment-core: 6 tasks, including two real correctness gaps found during review —PunishmentEntity.templateis a live reference, so editing a template retroactively changes historical punishment display (contradicts spec US5 AS2); deleting a still-referenced template throws an unhandled DB foreign-key exception instead of failing cleanly (contradicts FR-010)003-appeal-workflow: 3 tasks — converged furthest, since PR refactor(backend): extract appeal review logic into AppealDecisionService #123 also covered therevokedByaudit stamp and race-window Javadoc as follow-ups beyond the original ask006-player-reports: 4 tasks (non-atomicity Javadoc, DTO/Error-variant +ReportApiconsolidation, quickstart re-validation)Test plan