Amaresh - Team Member Tasks: Fix dark mode dropdown contrast - #5379
Open
amaresh2001 wants to merge 1 commit into
Open
Amaresh - Team Member Tasks: Fix dark mode dropdown contrast#5379amaresh2001 wants to merge 1 commit into
amaresh2001 wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a team member has scheduled time off, their row in the Team Member Tasks widget (Dashboard) shows a "[Name] Is Not Available this Week" overlay. In dark mode, the "Ready for Review" dropdown menu (View Link / Edit Link / mark complete / more work needed) rendered with near-white text on a near-white background, making it unreadable. This was one of two issues flagged; PR #5317 (sphurthy-timeoff-hotfix) addressed the functional click-through issue but did not fix this contrast bug.
https://www.loom.com/share/86f58e5b27a3496e998d82ed9f2b89e7
Related PRs (if any):
This is a follow-up to #5317, which fixed the dropdown's disabled/click-through behavior but left the dark mode contrast issue unresolved.
Main changes explained:
reviewButton.module.css: added the.dark-mode-btnclass (dark navy background#1c2541, light text, with hover/focus states), which was previously referenced inReviewButton.jsxbut never defined, so it silently did nothing. Also added.review-button-dropdown-darkfor the dropdown menu container's background.ReviewButton.jsx: bothDropdownMenuinstances (own-task view and reviewer view) now conditionally apply the new dark background class whendarkModeis true; all 6DropdownItemelements now conditionally applytext-light+dark-mode-btntogether only in dark mode (previously the CSS-module class was applied unconditionally regardless of mode, which was harmless only because it didn't exist).How to test:
amaresh/timeoff-review-dropdown-dark-modenpm installand run the app locallyreviewStatus: "Submitted"Screenshots or videos of changes:
Note: