Helm 4 support#2069
Open
hnrkndrssn wants to merge 4 commits into
Open
Conversation
hnrkndrssn
force-pushed
the
henrik/feat/hpy-1402-helm-4-support
branch
from
July 14, 2026 07:45
ff67ba0 to
354471e
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates Calamari’s Helm integration to work with Helm v4 (and future majors) by adjusting how the Helm client version is detected and validated, and by removing the now-removed --client flag from helm version.
Changes:
- Update Helm CLI version detection to use
helm version --short(no--client) and adjust related tests. - Replace the Helm version enum parsing with a major-version integer parser to allow Helm v4+.
- Update Helm upgrade executor validation logic and test mocks to accept Helm v4 output.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/Calamari/Kubernetes/Integration/HelmCli.cs | Switch Helm version command to version --short and update parsing comment. |
| source/Calamari/Kubernetes/Conventions/Helm/HelmUpgradeExecutor.cs | Validate supported Helm versions via parsed major version (allow v3+). |
| source/Calamari.Tests/KubernetesFixtures/Integration/HelmCliTests.cs | Update expected command-line arguments for Helm version invocation. |
| source/Calamari.Tests/KubernetesFixtures/HelmVersionParserFixture.cs | Update tests to cover major version parsing including v4/v5. |
| source/Calamari.Tests/KubernetesFixtures/HelmUpgradeFixture.cs | Remove Helm version helper code that depended on --client. |
| source/Calamari.Tests/KubernetesFixtures/Conventions/Helm/HelmUpgradeExecutorTests.cs | Update version mock to reflect Helm v4 output and remove --client assumption. |
| source/Calamari.Shared/Util/HelmVersionParser.cs | Replace enum parsing with ParseMajorVersion integer parsing. |
| source/Calamari.Shared/Util/HelmVersion.cs | Remove HelmVersion enum (no longer needed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the Helm version resolver to support v4 and future major version of Helm, and removing the
--clientargument fromhelm versionas it was a no-op in Helm v3 and removed in Helm v4.This PR does not upgrade the bundled helm version in Octopus, just adds support for customers who have installed helm v4 to use that version.
Before
After