taste: keep prescribed fixes minimal - #57
Merged
Merged
Conversation
Keep citing existing primitives. A Fix that adds lines is the wrong fix. Co-authored-by: Cursor <cursoragent@cursor.com>
![exe-dev-github-integration[bot]](https://avatars.githubusercontent.com/in/3061187?s=60&v=4){kind=small}
Removed the verbose "do not" sections from the review prompt and rubric, shifting the tone to concise, positive instructions. The "Do NOT flag" section in the rubric was dropped entirely, and the memory/convergence rules were tightened for clarity. Tests were updated to match the new prompt structure. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
| @@ -1,88 +1,23 @@ | |||
| # Review spec — corpus-grounded, anti-slop, with a personality | |||
| # Review spec | |||
There was a problem hiding this comment.
🟠 .review/REVIEW-PROMPT.md:1 · overbuilt · conf 0.91
This PR says it is only constraining prescribed fixes to stay minimal, but it rewrites the whole review contract and drops concrete safeguards around untrusted inputs, prior-review convergence, blocking vs non-blocking findings, and exact body formatting. The minimal change is a sentence in the existing fix guidance, not replacing the spec with a compressed version.
→ Fix: keep the existing spec/rubric text and add only the “delete/inline/call what's there; don't add LOC” constraint where fixes are prescribed.
Removed remaining verbose and scolding language from the prompt construction in `src/sweep/prompt.ts`. The intent, memory, and reraise sections are now much tighter and direct, focusing on positive instructions rather than ALL-CAPS security warnings. Co-authored-by: Cursor <cursoragent@cursor.com>
…notes Updated `REVIEW-PROMPT.md` to explicitly state that review cycles are expensive and only issues that truly break behavior or introduce tech debt should be flagged, while encouraging even lighter review on tests. Updated `RUBRIC.md` to explicitly discourage over-building and heavy-handed fixes, suggesting they be noted as non-blocking (e.g., race conditions) unless truly needed. Co-authored-by: Cursor <cursoragent@cursor.com>
Refine the "Weigh the fix" guidance to avoid prescribing heavy-handed fixes and to treat added lines as liability rather than a generic reuse-vs-add tradeoff. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun test src/review-sweep.test.tsMade with Cursor