*: add PayloadAttestation duty - #4618
Open
KaloyanTanev wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
branch-invalid
|
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares Charon internals for the Gloas hardfork by introducing the new payload timeliness/payload attestation duty type and the supporting consensus-spec plumbing (domain + intra-slot timing config), without yet wiring it into go-eth2-client or the full workflow.
Changes:
- Add
DutyPayloadAttestation(enum + string + constructor) and update duty-type compatibility tests. - Extend intra-slot timing config parsing to include Gloas payload-related deadlines (
PAYLOAD_DUE_BPS,PAYLOAD_ATTESTATION_DUE_BPS) and use the payload due time for payload-attestation slot offsets. - Add
DOMAIN_PTC_ATTESTERsupport to signing domain lookup, plus a unit test.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eth2util/signing/signing.go | Adds DOMAIN_PTC_ATTESTER domain name constant for spec-based domain resolution. |
| eth2util/signing/signing_test.go | Verifies GetDomain resolves DOMAIN_PTC_ATTESTER via overridden spec values. |
| core/types.go | Introduces DutyPayloadAttestation and a convenience constructor. |
| core/types_test.go | Updates backwards-compatibility and duty list tests for the new duty type. |
| core/slotoffset.go | Schedules DutyPayloadAttestation using the payload deadline basis points. |
| core/slotoffset_internal_test.go | Adds timing config fields and tests payload-attestation slot offsets around the Gloas fork. |
| app/eth2wrap/utils.go | Extends slot timing config parsing to include payload + payload attestation deadlines and clarifies fork-key handling. |
| app/eth2wrap/utils_test.go | Updates expected fetched timing config to include payload-related defaults. |
| app/eth2wrap/utils_internal_test.go | Expands parsing test cases for payload deadlines and validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DutyAggregator: timing.Aggregate, | ||
| DutySyncMessage: timing.SyncMessage, | ||
| DutySyncContribution: timing.Contribution, | ||
| DutyPayloadAttestation: timing.Payload, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gloas #4618 +/- ##
========================================
Coverage ? 57.91%
========================================
Files ? 246
Lines ? 34061
Branches ? 0
========================================
Hits ? 19728
Misses ? 11872
Partials ? 2461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new duty for gloas :). Only the internals here, without involving any go-eth2-client (meaning it's dead code as it stands).
category: feature
ticket: #4324