Add Mastra lockfile example and verified case study#498
Conversation
sonukapoor
left a comment
There was a problem hiding this comment.
Good study for an AI framework monorepo. Four direct findings with two command groups, and the workspace-scoped pnpm add vite@6.3.5 --filter playground is a concrete example of the filtered upgrade pattern. The size comparison to other fixtures in the repo (4,555 packages, largest in the set) is useful context. Single clean commit, all sections present.
|
After #474 merged today, this PR has conflicts in the shared files (README.md, CHANGELOG.md, examples/readme.md, website/sidebars.ts). Please rebase against main and push: git fetch upstream
git rebase upstream/main
# resolve any conflicts in README.md, examples/readme.md, sidebars.ts
git push --force-with-leaseThe review approval stands — this just needs a clean rebase. |
sonukapoor
left a comment
There was a problem hiding this comment.
Good content and structure — a few missing pieces before merge:
README not updated. The case studies list in README.md and the in-repo fixtures line ("Astro, Turborepo, and Visual Studio Code live under examples/...") both need entries for this project. Follow the pattern of the existing entries.
CHANGELOG entry missing. No CHANGELOG.md update in the diff. Add a line to the [Unreleased] section under ### Docs following the same one-line format as the other case study entries.
Add a row to website/docs/case-studies/index.md. A case studies index page was added after your branch was cut — it's on main now but missing an entry for this project. After rebasing you'll find it at website/docs/case-studies/index.md. Use the format from the existing rows as a guide.
Please also rebase against main before pushing — the branch is behind the v1.18.2 release.
Snapshot mastra-ai/mastra pnpm lockfile (4,555 packages, 64 findings) with full case study, local logo, pnpm audit comparison, and docs wiring (README, CHANGELOG, case studies index, examples readme, sidebar).
|
Thanks for the review @sonukapoor — addressed the missing pieces and rebased onto latest
I will update anything else you flag on this PR. Ready for another look. |
Summary
examples/mastra/from mastra-ai/mastra@e9d54b2 (package.json+pnpm-lock.yaml).website/docs/case-studies/mastra.md(4,555 packages, 64 findings, pnpm audit comparison).website/static/img/mastra-logo.svg(from repo playground assets).Test plan
npm run build && node dist/index.js examples/mastra --verbose --all— 64 findings (3 critical · 30 high · 25 medium · 6 low)pnpm audit(pnpm 11.3.0, Node 24) — 116 entries documented in case studycd website && npm run build— Docusaurus build succeedsMade with Cursor