Add Gatsby lockfile example and verified case study#494
Conversation
|
cc: @sonukapoor |
sonukapoor
left a comment
There was a problem hiding this comment.
The Gatsby study is solid — the Yarn Classic path limitation note sets honest expectations, the 5-direct/123-transitive split is well-explained, and the multi-major js-yaml situation is a nice detail. One thing before this merges: the branch has 3 commits. Please squash them into one (git rebase -i origin/main, then git push --force-with-lease) so the history stays clean.
sonukapoor
left a comment
There was a problem hiding this comment.
Good content and structure — a few missing pieces before merge:
README not updated. The case studies list in README.md and the in-repo fixtures line ("Astro, Turborepo, and Visual Studio Code live under examples/...") both need entries for this project. Follow the pattern of the existing entries.
CHANGELOG entry missing. No CHANGELOG.md update in the diff. Add a line to the [Unreleased] section under ### Docs following the same one-line format as the other case study entries.
Add a row to website/docs/case-studies/index.md. A case studies index page was added after your branch was cut — it's on main now but missing an entry for this project. After rebasing you'll find it at website/docs/case-studies/index.md. Use the format from the existing rows as a guide.
Please also rebase against main before pushing — the branch is behind the v1.18.2 release.
Snapshot gatsbyjs/gatsby Yarn Classic lockfile (3,568 packages, 128 findings) with full case study, local logo, yarn audit comparison, case studies index, README and CHANGELOG updates.
|
Thanks for the review @sonukapoor — addressed the requested updates:
I will update anything else you flag on this PR. Please take another look when you have a moment. |
sonukapoor
left a comment
There was a problem hiding this comment.
All feedback addressed — README, CHANGELOG, and index.md all updated, rebased cleanly against main. Good to merge.
Summary
examples/gatsby/from gatsbyjs/gatsby@1f38c85 (package.json+ Yarn Classicyarn.lock).website/docs/case-studies/gatsby.md(3,568 packages, 128 findings, yarn audit comparison).website/static/img/gatsby-logo.svgso the case study image loads reliably on the docs site.Test plan
npm run build && node dist/index.js examples/gatsby --verbose --all— 128 findings (9 critical · 66 high · 42 medium · 11 low)cd examples/gatsby && yarn audit— comparison numbers documented in case studycd website && npm run build— Docusaurus build succeeds/cve-lite-cli/docs/case-studies/gatsbyMade with Cursor