fix: correctly assign targetVersion for parent-update targets - #1121
Draft
RohithPariki wants to merge 4 commits into
Draft
fix: correctly assign targetVersion for parent-update targets#1121RohithPariki wants to merge 4 commits into
RohithPariki wants to merge 4 commits into
Conversation
Fixes OWASP#1007. Assigns the parent's currentVersion instead of the child's targetChildVersion to the parent-update target, preventing incorrect version merging for direct dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The
targetVersionforparent-updatewas being incorrectly populated with the child dependency's safe version (targetChildVersion). During map insertion, if the parent was also flagged as a direct finding, its correcttargetVersioncould be overwritten by this incorrect child version due to version comparison sorting, resulting in cross-wired suggested commands.This assigns
currentVersiontotargetVersionforparent-updatetargets, preventing incorrect version merging while correctly indicating no direct version change is needed in the UI.Closes #1007