fix/mobile-navbar-improvements#3062
Open
Adarshkumar0509 wants to merge 1 commit into
Open
Conversation
Replace the legacy mobile dropdown with a slide-out drawer, add the branded header logo, and apply mobile menu spacing from design review.
Adarshkumar0509
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
Contributor
Author
|
hii @sydseter please take a look at this. |
Collaborator
|
@Adarshkumar0509 instead of taking the user to /copi when pressing Play Online, could we instead be taken to https://copi.owasp.org/ ? |
Collaborator
|
Not very serious, but on Desktop and Pads the Ge Cornucopia sub-menu is pulling a lot to the left for no reason. Which disturbs a bit. On IPad Mini (Using the Chrome developer tools and selecting the device), the Play online is pushing against the frame so that you get a white vertical border. I am not sure what is the best here. Either hide it, or make it scrollable. Perhaps I have a soultion for you. Instead of "Play Online" simply use "Play". That will probably take care of it. When the user presses the button, take them to copi.owasp.org 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redesigns the OWASP Cornucopia site header navigation to match the mobile/desktop layout from the redesign demo, with mentor feedback applied.
Changes:
1.} Replace the legacy mobile dropdown with a left slide-out drawer (backdrop, hamburger toggle, section label for “Get Cornucopia” sublinks).
2.} Add the OWASP wordmark header logo (cornucopia_logo_white_with_text_owasp.svg) instead of plain text branding.
3.} Keep desktop navigation: horizontal links, “Get Cornucopia” checkbox dropdown, and “Play Online” CTA.
4.} Scope nav CSS to .top-nav / .mobile-drawer so global nav flex rules no longer break the drawer layout.
5.} Mobile menu: tighter vertical spacing, readable font sizes, smaller “Play Online” button, no language list in the drawer (per design review).
fixed issue: #2194
AI Tool Disclosure
Affirmation