ci: Make the oelint-adv gate blocking#122
Merged
Merged
Conversation
The crate:// fetcher URIs in these autogenerated -crates.inc files all resolve to crates.io, so the inline 'nooelint: oelint.vars.srcuridomains' exceptions added when the rule misfired are no longer needed: the oelint-adv carried by the yocto-env.nix '#lint' devshell (now 9.8.4) no longer reports srcuridomains for them and instead flags the exceptions themselves via oelint.file.inlinesuppress_na. Remove the two exception lines so the layer lints clean. The lines are not emitted by the cargo update_crates generator, so regenerating these files will not bring them back. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Drop continue-on-error from the OE Lint job so any oelint-adv finding fails the workflow. The job was advisory because released oelint-adv still tripped two false positives on our recipes (oelint-adv #889 gomod SRC_URI support and oelint-parser #383 leftover-buffer drain). Both fixes are now carried by the github:OSSystems/yocto-env.nix '#lint' devshell the workflow uses, so the generated telegraf-go-mods.inc and the custom task handlers lint clean and the gate can enforce. Verified the layer lints clean (oelint-adv 9.8.4, zero findings) with the stale crate suppressions removed in the preceding commit. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
otavio
force-pushed
the
oelint-blocking-gate
branch
from
e0cd114 to
3602d9d
Compare
mohlerj523-boop
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the OE Lint workflow a blocking gate now that the upstream
oelint-adv fixes ride in the shared
yocto-env.nix '#lint'devshell.recipes: Drop stale srcuridomains nooelint exceptions— thecrate://URIs in the autogeneratedeasysplash-crates.incandwifi-connect-4.11.84-crates.incall resolve to crates.io, so theinline
nooelint: oelint.vars.srcuridomainsexceptions no longerapply. oelint-adv 9.8.4 instead flags them via
oelint.file.inlinesuppress_na. The lines are not emitted by thecargo
update_cratesgenerator, so regeneration won't reintroducethem.
ci: Make the oelint-adv gate blocking— dropcontinue-on-errorso any finding fails the job. The two falsepositives that kept it advisory (oelint-adv #889 gomod SRC_URI
support, oelint-parser #383 leftover-buffer drain) are now carried by
the
#lintdevshell.Test
./contrib/oelint/run-oelint.shwith oelint-adv 9.8.4 → 0 findings,exit 0.