Modernize meta-ossystems-base for oelint-adv (wrynose)#119
Open
otavio wants to merge 36 commits into
Open
Conversation
Use ${UNPACKDIR} for the unpacked source directory, drop the deprecated
SRC_URI[md5sum], update LICENSE to the SPDX 'GPL-2.0-only' identifier, and
add the required Upstream-Status (and a carried Signed-off-by) to
linux-input.patch.
Tested: bitbake beep (MACHINE=qemuarm, DISTRO=oel).
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Read the unpacked source and the fetched udev rules / service files from
${UNPACKDIR}, and update LICENSE to the SPDX 'GPL-2.0-only' identifier.
Upstream's Makefile installs js-set-enum-leds and
80-stelladaptor-joystick.rules to a hardcoded /lib/udev. With usrmerge
${base_libdir} is /usr/lib, so those files did not match FILES:joystick and
triggered an 'installed but not shipped' QA failure; relocate the hardcoded
/lib content under ${base_libdir} in do_install.
Tested: bitbake linuxconsole (the joystick package ships the udev helper
and rules under /usr/lib/udev).
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Use ${UNPACKDIR} for the unpacked sources, the cargo paths and the
installed service files, and append to DEPENDS instead of overwriting it
after the require.
Tested: parsed with bitbake -e; a full build needs meta-networking
(networkmanager) which is not part of this build configuration.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Install the configuration file from ${UNPACKDIR} and update LICENSE and
LIC_FILES_CHKSUM to the SPDX 'GPL-2.0-only' identifier.
Tested: bitbake inputattach-config.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The fetched script, default and service files now unpack under
${UNPACKDIR} (= ${WORKDIR}/sources) on current OE, so install them from
there instead of ${WORKDIR}.
Tested: bitbake net-persistent-mac.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Install the fetched default, service, script and udev rule files from
${UNPACKDIR} instead of ${WORKDIR}.
Tested: parsed with bitbake -e.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Install the fetched initd, service and default files from ${UNPACKDIR}
instead of ${WORKDIR} in chromium-ozone-wayland-init.
Tested: parsed with bitbake -e; a full build needs the chromium browser
layer which is not part of this build configuration.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Install the fetched initd, service, default and conf files from
${UNPACKDIR} instead of ${WORKDIR} in qt-kiosk-browser-init.
Tested: parsed with bitbake -e; a full build needs meta-qt5 which is not
part of this build configuration.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Install the fetched options file from ${UNPACKDIR} instead of
${WORKDIR}.
Tested: parsed with bitbake -e.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Use ${localstatedir} in the tmpfiles.d entry rather than a hardcoded
/var path.
Tested: parsed with bitbake -e.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Use 'install -d' rather than 'mkdir -p' to create directories in do_install, as recommended for recipe tasks. Tested: bitbake net-persistent-mac (inherits this class). Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
…cense metadata
Inherit release-bundle so RELEASE_BUNDLE_TMP_DOWNLOAD_CACHE is defined for
the generator. Without it the variable expanded empty, turning the
download-cache copy into a destructive 'cp -L /*/*'. Guard that copy so it
is a no-op when RELEASE_BUNDLE_RECIPES_WITH_SOURCE collected nothing, and
read bundle-shar-extract.sh from ${UNPACKDIR}.
Move LICENSE and LIC_FILES_CHKSUM into the class so generate-release-bundle.bb
stays minimal (just SUMMARY and the inherit).
Tested: bitbake generate-release-bundle produced the self-extracting bundle
(.sh) with the expected shar header and embedded payload.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add ossystems-constants.json declaring the layer's custom variables and machine/distro overrides, and run-oelint.sh to run oelint-adv over the OSSystems layers with the project's suppressions, reducing false positives from running outside a full bitbake build. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add the missing DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION (and SUMMARY/LICENSE for the psplash initramfs image) so these core recipes carry full metadata and satisfy the mandatory-variable QA checks. Internal recipes reference the meta-ossystems-base repository for HOMEPAGE/BUGTRACKER. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add the missing SUMMARY, DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION so these recipes carry full metadata and satisfy the mandatory-variable QA checks. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Complete the recipe metadata required by the mandatory- and suggested-variable QA checks. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Complete the recipe metadata, pointing HOMEPAGE/BUGTRACKER at the upstream project. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION so the recipe carries full metadata. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION so the recipe carries full metadata. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION so the recipe carries full metadata. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION, pointing at the upstream project. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add DESCRIPTION, HOMEPAGE, BUGTRACKER and SECTION so the recipe carries full metadata. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The recipe special-cased the long-defunct SlugOS distro to install
beep into ${base_bindir} through a BINDIR_slugos override that also
used the pre-3.x underscore override syntax. SlugOS has been dead for
over a decade and is not built here, so the override never fires and
the BINDIR indirection is dead code.
Drop the BINDIR variable and install directly into ${bindir}.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
debug-tweaks enables passwordless root login, which is a security risk. This image only shows a psplash boot splash before pivoting to the real rootfs and has no need for an interactive passwordless shell, so the feature is dropped. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Add task[doc] documentation flags to the custom tasks, post-process command functions and event handlers in the OSSystems classes so they are described in 'bitbake -e' and listtasks output. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Strip trailing spaces from two comment lines in cve-filter and remove the double blank lines in image-license-checker. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Normalise tab indentation to spaces in net-persistent-mac's do_install, drop the redundant leading space in list assignments (collapse the now single-entry IMAGE_FEATURES in initramfs-psplash-image, and the '+= " ...' / '= " ...' forms in ossystems-minimal-initramfs and initramfs-framework-psplash), and reorder SRC_URI/S/PACKAGES/FILES in initramfs-framework-psplash into the canonical order. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Use a single space around the SRC_URI assignment and normalise tab indentation to spaces in beep's do_install, and drop the redundant leading space in the SRC_URI append of wifi-connect and its generated crates include. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Collapse the aligned ?= padding to a single space, drop the redundant leading space in qt-kiosk-browser-init's SRC_URI, remove a double blank line, and move PACKAGE_ARCH before RDEPENDS in both the chromium and qt-kiosk browser init recipes. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Collapse the aligned COG_URL ?= padding to a single space and move PACKAGE_ARCH before RDEPENDS. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
LIC_FILES_CHKSUM paths are already resolved relative to ${S}, so the
explicit prefix is redundant.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Drop the redundant leading space in the RDEPENDS append and place the FILES assignment before RDEPENDS, matching the canonical order. No functional change. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The lint helper previously scanned meta-ossystems-base and meta-secure-boot together, but meta-secure-boot carries uncommitted local work and was never in play. Narrow the runner to this layer for consistency and drop the constants that were only needed for meta-secure-boot (the mx*-generic-bsp, hab4 and ahab machine overrides, BOOT_CONFIG_MACHINE and SIGNED_TARGET); none of them are referenced under meta-ossystems-base. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The upstream Makefile hardcodes the udev directory to /lib/udev, which
under usrmerge is the wrong location and previously required relocating
${D}/lib into ${base_libdir} after install.
Follow the OE-core convention instead (as nfs-utils does): sed the
Makefile to honour ${nonarch_base_libdir}, and install the local udev
rules directly to ${nonarch_base_libdir}/udev/rules.d. This drops the
post-install relocation block and is multilib-correct.
Built for qemuarm/oel with usrmerge: the joystick package ships
js-set-enum-leds and all rules under /usr/lib/udev with no
installed-but-not-shipped QA.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Drop the verbose usage/requirements/scope preamble; keep a one-line purpose and the rule-suppression rationale. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The inherit line is self-explanatory; remove the comment restating what the inherited class provides. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An
oelint-adv(releasewrynose) cleanup and modernization pass overmeta-ossystems-base. Raw findings dropped from 382 → 144, with theremainder being accepted info-level items or documented false positives.
meta-secure-bootis intentionally out of scope.What's included
${WORKDIR}→${UNPACKDIR}for fetchedsources (incl. task-body refs that oelint's
unpackdirrule misses),mkdir→install -d, deprecatedSRC_URI[md5sum]removal, deadslugosspecial-case removal in
beep, obsolete SPDX license IDs(
GPLv2/GPL-2.0→GPL-2.0-only), andDEPENDS/LIC_FILES_CHKSUMfixes./lib→${base_libdir}relocation with the OE-core canonical pattern:
sedthe upstream Makefile tohonour
${nonarch_base_libdir}and install udev rules directly there.LICENSE completed across 16 recipes.
blank lines, assignment spacing, canonical variable order.
debug-tweaksfrom the psplash initramfs,added
task[doc]strings to custom tasks; documented the accepted items.contrib/oelint/run-oelint.sh+ossystems-constants.jsontoreproduce the run with the project's constant-DB additions and suppressions.
Validation
bitbake -p: 969 recipes parse, 0 errors.linuxconsolebuilt for qemuarm/oel (usrmerge): thejoystickpackage shipsjs-set-enum-ledsand all udev rules under/usr/lib/udevwith noinstalled-but-not-shipped QA.
beep,net-persistent-mac,inputattach-config,full release bundle) build-validated GREEN.