Skip to content

336: Avoided inheriting data on page transition #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jekuaitk wants to merge 2 commits into
base: develop
Choose a base branch
from
+10 −0
Open

336: Avoided inheriting data on page transition #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06fdf29
336: Avoided inheriting data on page transition
jekuaitk Jun 26, 2026
badc51f
336: Updated CHANGELOG
jekuaitk Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ before starting to add changes. Use example [placed in the end of the page](#exa

## [Unreleased]

- [337](https://github.com/OS2Forms/os2forms/pull/337)
Avoid inheriting data on page transition in MaestroWebformInheritTask.

## [5.1.0] 2026-06-03

- [PR-326](https://github.com/OS2Forms/os2forms/pull/326)
Expand Down
7 changes: 7 additions & 0 deletions modules/os2forms_forloeb/src/Plugin/EngineTasks/MaestroWebformInheritTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ public function prepareTaskForSave(array &$form, FormStateInterface $form_state,
* Implements hook_webform_submission_form_alter().
*/
public static function webformSubmissionFormAlter(array &$form, FormStateInterface $formState, string $formId) {
// Only inherit values on the initial form load. This skip condition is the
// complement of webform's own prepopulate guard.
// @see \Drupal\webform\WebformSubmissionForm::buildForm()
if ($formState->isRebuilding() && !$formState->get('is_ajax_restart')) {
return;
}

// @todo Clean up and align with MaestroHelper::maestroZeroUserNotification().
if ($queueID = self::getQueueIdFromRequest()) {
$templateTask = MaestroEngine::getTemplateTaskByQueueID($queueID);
Expand Down
Loading