Conversation
|
@Anna-itk vil I lave review af denne PR? |
|
@ChatBotBerg vil du godkende codereview på 5 timer? Vi kan igangsætte opgaven når Anna Lis har godkendt. |
martinyde
left a comment
There was a problem hiding this comment.
Looks good.
If i understand correct it sets all filters using ckeditor4 to use some default config for ckeditor5. So the release notes should probably mention something about the need to reconfigure the Filterformats manually, but thats not related to the code, but rather a communication task.
Function computeSmartDefaultSettings is doing a better job than this, what id does based on the documentation: "Computes the closest possible equivalent settings for switching to CKEditor 5." I've tested it with few CKEdtior4 settings and in my opinion it does quite a good job for keeping the functionality. |
Issue: #200