Skip to content

#200 updating ckeditor -> ckeditor5#326

Merged
stankut merged 4 commits intodevelopfrom
f/200_ckeditor_upgrade
May 8, 2026
Merged

#200 updating ckeditor -> ckeditor5#326
stankut merged 4 commits intodevelopfrom
f/200_ckeditor_upgrade

Conversation

@stankut
Copy link
Copy Markdown
Collaborator

@stankut stankut commented May 4, 2026

Issue: #200

@ds-bellcom
Copy link
Copy Markdown
Contributor

@Anna-itk vil I lave review af denne PR?

@lilosti
Copy link
Copy Markdown

lilosti commented May 7, 2026

@ChatBotBerg vil du godkende codereview på 5 timer? Vi kan igangsætte opgaven når Anna Lis har godkendt.

Copy link
Copy Markdown
Collaborator

@martinyde martinyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
If i understand correct it sets all filters using ckeditor4 to use some default config for ckeditor5. So the release notes should probably mention something about the need to reconfigure the Filterformats manually, but thats not related to the code, but rather a communication task.

@stankut
Copy link
Copy Markdown
Collaborator Author

stankut commented May 8, 2026

Looks good. If i understand correct it sets all filters using ckeditor4 to use some default config for ckeditor5. So the release notes should probably mention something about the need to reconfigure the Filterformats manually, but thats not related to the code, but rather a communication task.

Function computeSmartDefaultSettings is doing a better job than this, what id does based on the documentation: "Computes the closest possible equivalent settings for switching to CKEditor 5."

I've tested it with few CKEdtior4 settings and in my opinion it does quite a good job for keeping the functionality.

@stankut stankut merged commit d0301c6 into develop May 8, 2026
8 checks passed
@stankut stankut deleted the f/200_ckeditor_upgrade branch May 8, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modulet "CKEditor 4 (contrib) (ckeditor)" bør erstattes (af "CKEditor 5 (ckeditor5)") da det er deprecated

4 participants