Future proof exciters - #557
Merged
Merged
Conversation
lukelowry
force-pushed
the
lukel/exciter-future-dev
branch
from
August 29, 2026 01:15
3489423 to
e443aed
Compare
Collaborator
Author
|
@nkoukpaizan Ready |
lukelowry
marked this pull request as ready for review
August 31, 2026 15:43
nkoukpaizan
reviewed
Aug 31, 2026
nkoukpaizan
left a comment
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
A couple of comments. Otherwise looks good.
| // Set input variables. | ||
| if (signals_.template isAttached<Ieeet1ExternalVariables::OMEGA>()) | ||
| // Attached signals are read live; unattached ones keep the latched value. | ||
| auto read_signal = [&]<Ieeet1ExternalVariables variable>(const ScalarT& latched) |
Collaborator
There was a problem hiding this comment.
As @superwhiskers pointed out in another PR, we need to be thinking about ways to extract these common helper lambdas.
Collaborator
Author
There was a problem hiding this comment.
I agree, these are temporary until the external api is enhanced (@PhilipFackler and slaven were working on this in a recent PR).
Collaborator
Author
|
@nkoukpaizan let me know what you think. |
nkoukpaizan
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few changes since we have not released yet that will help with future-proofing this version of GridKit
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None