Edge case gates for IEEET1 (Validation)#487
Open
lukelowry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few edge-case guards for parameters that caused the unsimplified versions of our examples to fail.
Proposed changes
Tr,Ta,Te, andTfto prevent singular residual equations.Se1 = Se2 = 0as disabled saturation and validate enabled saturation parameters before deriving the coefficients.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Changelog changes N/A; this is a minor correction to an existing model.
Further comments
This preserves the existing fixed-size IEEET1 structure and allows the unsimplified example data to run without case-file changes. A structural treatment of zero time constants can be considered separately and is the preferred approach. I noticed that making the time constant nonzero, rather than zero, dramatically slows the simulation.